Skip to content

[wakelock_plus] Remove Ecore API#1031

Merged
JSUYA merged 1 commit into
flutter-tizen:masterfrom
JSUYA:wakelock_plus_remove_ecore
Jun 16, 2026
Merged

[wakelock_plus] Remove Ecore API#1031
JSUYA merged 1 commit into
flutter-tizen:masterfrom
JSUYA:wakelock_plus_remove_ecore

Conversation

@JSUYA

@JSUYA JSUYA commented Jun 12, 2026

Copy link
Copy Markdown
Member

Change ecore api to glib api.

flutter-tizen/embedder#146

@JSUYA JSUYA self-assigned this Jun 12, 2026
@JSUYA JSUYA added the enhancement New feature or request label Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the Ecore API with GLib's timeout API for managing screensaver reset timeouts in the Tizen implementation of the wakelock_plus plugin. Review feedback identifies two issues: first, when the GLib timeout callback returns G_SOURCE_REMOVE, the timer_id_ is not reset to 0, leaving a stale ID; second, the dynamic library handle screensaver_api_handle_ is not closed in the destructor, leading to a potential resource leak.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/wakelock_plus/tizen/src/wakelock_plus_tizen_plugin.cc
Comment thread packages/wakelock_plus/tizen/src/wakelock_plus_tizen_plugin.cc
Change ecore api to glib api.
@JSUYA
JSUYA merged commit 4795039 into flutter-tizen:master Jun 16, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request p: wakelock_plus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants