[audioplayers] Remove Ecore API#1033
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the Ecore API with GLib APIs for idle callbacks and timers in the Tizen AudioPlayer implementation, and updates the package version to 3.1.4. The review feedback identifies potential Use-After-Free vulnerabilities when using g_idle_add on background threads. To address this, the feedback suggests implementing a lifetime tracker using std::shared_ptr and std::weak_ptr, and refactoring the callbacks to use g_idle_add_full to safely verify the player's existence before execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Replace the Ecore main-loop and timer APIs with their GLib APIs.
4fb64af to
b3b99f3
Compare
ecore_main_loop_thread_safe_call_async was removed in the Ecore API cleanup (flutter-tizen#1033). Replace the two remaining usages in OnInterrupted and OnError with g_idle_add_full, consistent with OnPrepared, OnSeekCompleted, and OnPlayCompleted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ecore_main_loop_thread_safe_call_async was removed in the Ecore API cleanup (flutter-tizen#1033). Replace the two remaining usages in OnInterrupted and OnError with g_idle_add_full, consistent with OnPrepared, OnSeekCompleted, and OnPlayCompleted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
Replace the Ecore main-loop and timer APIs with their GLib APIs.
flutter-tizen/embedder#146