Skip to content

[video_player] Remove Ecore API#1034

Merged
xiaowei-guan merged 5 commits into
flutter-tizen:masterfrom
gin7773:video_player-remove-ecore
Jun 17, 2026
Merged

[video_player] Remove Ecore API#1034
xiaowei-guan merged 5 commits into
flutter-tizen:masterfrom
gin7773:video_player-remove-ecore

Conversation

@gin7773

@gin7773 gin7773 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Fix #1032
Fix #958
Main changes:

  • Replace Ecore API with glib API.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the Ecore API with GLib APIs for event dispatching and screensaver timeout management in the Tizen video player implementation. Feedback on these changes identifies potential deadlocks from lock order inversion in PushEvent and SendError, a potential resource leak of main_context_ if construction fails, and a potential GLib warning if timer_id_ is not properly reset upon source destruction.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/video_player/tizen/src/video_player.cc Outdated
Comment thread packages/video_player/tizen/src/video_player.cc Outdated
Comment thread packages/video_player/tizen/src/video_player.h Outdated
Comment thread packages/video_player/tizen/src/video_player.cc
Comment thread packages/video_player/tizen/src/video_player.cc Outdated
Comment thread packages/video_player/tizen/src/video_player.cc Outdated
Comment thread packages/video_player/tizen/src/video_player.cc Outdated
@xiaowei-guan
xiaowei-guan merged commit 0c7d2d5 into flutter-tizen:master Jun 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[video_player] Change ecore api to glib api for timer [video_player] Replace ecore with tcore

3 participants