Skip to content

Commit cd9f17f

Browse files
committed
Apply gemini's review comments
1 parent 7c80ea5 commit cd9f17f

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

pubspec.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ dependencies:
1212
dev_dependencies:
1313
ffigen: ^11.0.0
1414
lints: ^3.0.0
15+
path: ^1.9.1
1516
symgen:
1617
path: packages/symgen

scripts/convert_description.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import 'dart:collection';
22
import 'dart:io';
33

4+
import 'package:path/path.dart' as p;
5+
46
const _doxygenTags = <String>[
57
'brief',
68
'details',
@@ -50,7 +52,7 @@ final _codeBlockStartRegExp = RegExp(
5052
final _versionedTizenLibraryPathRegExp = RegExp(
5153
r'(^|[\\/])lib[\\/](\d+\.\d+)[\\/]tizen\.dart$',
5254
);
53-
final _pathSeparatorRegExp = RegExp(r'[\\/]');
55+
final _listRegExp = RegExp(r'^\d+\.\s');
5456
final _topLevelDeclarationRegExp = RegExp(
5557
r'^(typedef|(?:abstract|final)\s+class|class|enum)\s+',
5658
);
@@ -172,7 +174,7 @@ void main(List<String> args) {
172174
if (bindingDir.existsSync()) {
173175
for (final entry in bindingDir.listSync()) {
174176
if (entry is File) {
175-
final fileName = entry.path.split(_pathSeparatorRegExp).last;
177+
final fileName = p.basename(entry.path);
176178
if (fileName.startsWith('generated_bindings') &&
177179
fileName.endsWith('.dart')) {
178180
pathsToProcess.add(entry.path);
@@ -311,7 +313,7 @@ bool _shouldHideTopLevelGeneratedBindingsDeclarations(String? path) {
311313
return false;
312314
}
313315

314-
final fileName = path.split(_pathSeparatorRegExp).last;
316+
final fileName = p.basename(path);
315317
return fileName == 'generated_bindings.dart';
316318
}
317319

@@ -1064,7 +1066,7 @@ String _mergeDocText(String current, String next) {
10641066
final nextTrimmed = next.trimLeft();
10651067
if (nextTrimmed.startsWith('- ') ||
10661068
nextTrimmed.startsWith('* ') ||
1067-
RegExp(r'^\d+\.\s').hasMatch(nextTrimmed)) {
1069+
_listRegExp.hasMatch(nextTrimmed)) {
10681070
return '$current\n$next';
10691071
}
10701072
return '$current $next';

0 commit comments

Comments
 (0)