Update generator_callbacks scripts to handle individual modules - #71
Merged
seungsoo47 merged 4 commits intoApr 24, 2026
Conversation
seungsoo47
commented
Apr 20, 2026
Contributor
- Modify generate_callbacks.sh to process individual ffigen_*.yaml configs.
- Replace line-based parsing with regex to correctly handle multi-line typedef declarations.
- Add missing callback functions.
There was a problem hiding this comment.
Code Review
This pull request updates the callback generator to support multiple ffigen configurations per Tizen version and improves the robustness of the parsing logic. Key changes include adding bounds checks in the comment reader, switching to regex-based typedef extraction, and modifying header discovery to include all headers in a directory when a match is found. Feedback was provided to improve the typedef regex to handle indentation, ensure UTF-8 encoding when reading files, use warnings for unsupported patterns, and utilize Bash arrays for command arguments to safely handle paths with spaces.
JSUYA
reviewed
Apr 23, 2026
JSUYA
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.