Skip to content

Update generator_callbacks scripts to handle individual modules - #71

Merged
seungsoo47 merged 4 commits into
flutter-tizen:mainfrom
seungsoo47:dev.tizen_interop.callback_generator.260420_2
Apr 24, 2026
Merged

Update generator_callbacks scripts to handle individual modules#71
seungsoo47 merged 4 commits into
flutter-tizen:mainfrom
seungsoo47:dev.tizen_interop.callback_generator.260420_2

Conversation

@seungsoo47

Copy link
Copy Markdown
Contributor
  • Modify generate_callbacks.sh to process individual ffigen_*.yaml configs.
  • Replace line-based parsing with regex to correctly handle multi-line typedef declarations.
  • Add missing callback functions.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the callback generator to support multiple ffigen configurations per Tizen version and improves the robustness of the parsing logic. Key changes include adding bounds checks in the comment reader, switching to regex-based typedef extraction, and modifying header discovery to include all headers in a directory when a match is found. Feedback was provided to improve the typedef regex to handle indentation, ensure UTF-8 encoding when reading files, use warnings for unsupported patterns, and utilize Bash arrays for command arguments to safely handle paths with spaces.

Comment thread scripts/callbacks_generator/gen_callbacks.py Outdated
Comment thread scripts/callbacks_generator/gen_callbacks.py Outdated
Comment thread scripts/generate_callbacks.sh Outdated
Comment thread packages/tizen_interop_callbacks/tizen/src/types.h
@seungsoo47
seungsoo47 merged commit 8a2cea2 into flutter-tizen:main Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants