Skip to content

Fix generate_doc_script.py bugs - #72

Merged
seungsoo47 merged 2 commits into
flutter-tizen:mainfrom
seungsoo47:dev.tizen_interop.doc_script.260420
Apr 24, 2026
Merged

Fix generate_doc_script.py bugs#72
seungsoo47 merged 2 commits into
flutter-tizen:mainfrom
seungsoo47:dev.tizen_interop.doc_script.260420

Conversation

@seungsoo47

Copy link
Copy Markdown
Contributor
  • Update the parsing logic in generate_doc_script.py to correctly identify module Getters.
  • Regenerate all documentation files to include missing APIs.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the regex in the documentation generation script to match _getTizenInstance calls. A review comment points out that the new regex is too broad and could lead to incorrect matches across multiple getter definitions, suggesting a more restrictive pattern and the restoration of explanatory comments for maintainability.

Comment thread scripts/generate_doc_script.py Outdated
@seungsoo47
seungsoo47 force-pushed the dev.tizen_interop.doc_script.260420 branch from 07d3125 to e18d3e6 Compare April 24, 2026 01:01
@seungsoo47
seungsoo47 merged commit 62592f8 into flutter-tizen:main Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants