Skip to content

Commit 1220d8e

Browse files
committed
refactor: Update color opacity application to withValues(alpha:) and refine test variable declarations and Future types.
1 parent 133d00f commit 1220d8e

3 files changed

Lines changed: 16 additions & 15 deletions

File tree

dashboard/lib/widgets/guard_status.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ class GuardStatus extends StatelessWidget {
3030
vertical: isDense ? 1 : 2,
3131
),
3232
decoration: BoxDecoration(
33-
color: statusColor.withOpacity(0.1),
33+
color: statusColor.withValues(alpha: 0.1),
3434
borderRadius: BorderRadius.circular(12),
35-
border: Border.all(color: statusColor.withOpacity(0.2)),
35+
border: Border.all(color: statusColor.withValues(alpha: 0.2)),
3636
),
3737
child: showText
3838
? Text(

dashboard/test/state/presubmit_test.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ void main() {
6363
test(
6464
'PresubmitState update method updates properties and notifies listeners',
6565
() {
66-
bool notified = false;
66+
var notified = false;
6767
presubmitState.addListener(() => notified = true);
6868

6969
presubmitState.update(repo: 'cocoon', pr: '123', sha: 'abc');
@@ -96,7 +96,7 @@ void main() {
9696
);
9797

9898
presubmitState.pr = '123';
99-
bool notified = false;
99+
var notified = false;
100100
presubmitState.addListener(() => notified = true);
101101

102102
await presubmitState.fetchAvailableShas();
@@ -124,7 +124,7 @@ void main() {
124124
);
125125

126126
presubmitState.sha = 'sha1';
127-
bool notified = false;
127+
var notified = false;
128128
presubmitState.addListener(() => notified = true);
129129

130130
await presubmitState.fetchGuardStatus();
@@ -144,7 +144,7 @@ void main() {
144144
// Use update to stabilize the state including lastFetched flags
145145
presubmitState.update(repo: 'flutter', pr: '123', sha: 'abc');
146146

147-
bool notified = false;
147+
var notified = false;
148148
presubmitState.addListener(() => notified = true);
149149

150150
presubmitState.update(repo: 'flutter', pr: '123', sha: 'abc');

dashboard/test/views/presubmit_view_test.dart

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ void main() {
153153
);
154154
for (var i = 0; i < 50; i++) {
155155
await tester.pump();
156-
await Future.delayed(const Duration(milliseconds: 50));
156+
await Future<void>.delayed(const Duration(milliseconds: 50));
157157
if (find.textContaining('by dash').evaluate().isNotEmpty) break;
158158
}
159159
});
@@ -224,7 +224,7 @@ void main() {
224224
);
225225
for (var i = 0; i < 50; i++) {
226226
await tester.pump();
227-
await Future.delayed(const Duration(milliseconds: 50));
227+
await Future<void>.delayed(const Duration(milliseconds: 50));
228228
if (find.textContaining('by dash').evaluate().isNotEmpty) break;
229229
}
230230
});
@@ -236,7 +236,7 @@ void main() {
236236
await tester.runAsync(() async {
237237
for (var i = 0; i < 50; i++) {
238238
await tester.pump();
239-
await Future.delayed(const Duration(milliseconds: 50));
239+
await Future<void>.delayed(const Duration(milliseconds: 50));
240240
if (find.textContaining('All tests passed').evaluate().isNotEmpty) {
241241
break;
242242
}
@@ -291,7 +291,7 @@ void main() {
291291
// Wait for summaries, then latest SHA selection, then guard status fetch
292292
for (var i = 0; i < 50; i++) {
293293
await tester.pump();
294-
await Future.delayed(const Duration(milliseconds: 50));
294+
await Future<void>.delayed(const Duration(milliseconds: 50));
295295
final state = Provider.of<PresubmitState>(
296296
tester.element(find.byType(PreSubmitView)),
297297
listen: false,
@@ -325,7 +325,7 @@ void main() {
325325
);
326326
for (var i = 0; i < 20; i++) {
327327
await tester.pump();
328-
await Future.delayed(const Duration(milliseconds: 50));
328+
await Future<void>.delayed(const Duration(milliseconds: 50));
329329
if (find.byType(ShaSelector).evaluate().isNotEmpty) break;
330330
}
331331
});
@@ -400,7 +400,7 @@ void main() {
400400
);
401401
for (var i = 0; i < 20; i++) {
402402
await tester.pump();
403-
await Future.delayed(const Duration(milliseconds: 50));
403+
await Future<void>.delayed(const Duration(milliseconds: 50));
404404
if (find.textContaining('by dash').evaluate().isNotEmpty) break;
405405
}
406406
});
@@ -410,9 +410,10 @@ void main() {
410410
await tester.runAsync(() async {
411411
for (var i = 0; i < 20; i++) {
412412
await tester.pump();
413-
await Future.delayed(const Duration(milliseconds: 50));
414-
if (find.textContaining('Live log content').evaluate().isNotEmpty)
413+
await Future<void>.delayed(const Duration(milliseconds: 50));
414+
if (find.textContaining('Live log content').evaluate().isNotEmpty) {
415415
break;
416+
}
416417
}
417418
});
418419
await tester.pumpAndSettle();
@@ -509,7 +510,7 @@ void main() {
509510
);
510511
for (var i = 0; i < 20; i++) {
511512
await tester.pump();
512-
await Future.delayed(const Duration(milliseconds: 50));
513+
await Future<void>.delayed(const Duration(milliseconds: 50));
513514
if (find.textContaining('by dash').evaluate().isNotEmpty) break;
514515
}
515516
});

0 commit comments

Comments
 (0)