Skip to content

Commit 154bc47

Browse files
authored
Always re-run release builders from ToT. (#4687)
Closes flutter/flutter#168944.
1 parent dd59cbb commit 154bc47

2 files changed

Lines changed: 11 additions & 7 deletions

File tree

app_dart/lib/src/service/luci_build_service.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,8 @@ class LuciBuildService {
11531153
final result = await _buildBucketClient.scheduleBuild(
11541154
bbv2.ScheduleBuildRequest(
11551155
builder: builderId,
1156-
exe: bbv2.Executable(cipdVersion: 'refs/heads/${commit.branch}'),
1156+
// Release builds intentionally use ToT for recipe branches.
1157+
exe: null,
11571158
gitilesCommit: bbv2.GitilesCommit(
11581159
project: 'mirrors/${commit.slug.name}',
11591160
host: 'flutter.googlesource.com',

app_dart/test/service/luci_build_service/rerun_dart_internal_test.dart

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,9 @@ void main() {
141141
),
142142
);
143143
expect(
144-
request.exe,
145-
bbv2.Executable(cipdVersion: 'refs/heads/flutter-0.42-candidate.0'),
144+
request.hasExe(),
145+
isFalse,
146+
reason: 'Release recipes always run from ToT',
146147
);
147148
expect(
148149
request.gitilesCommit,
@@ -252,8 +253,9 @@ void main() {
252253
),
253254
);
254255
expect(
255-
request.exe,
256-
bbv2.Executable(cipdVersion: 'refs/heads/flutter-0.42-candidate.0'),
256+
request.hasExe(),
257+
isFalse,
258+
reason: 'Release recipes always run from ToT',
257259
);
258260
expect(
259261
request.gitilesCommit,
@@ -335,8 +337,9 @@ void main() {
335337
),
336338
);
337339
expect(
338-
request.exe,
339-
bbv2.Executable(cipdVersion: 'refs/heads/flutter-0.42-candidate.0'),
340+
request.hasExe(),
341+
isFalse,
342+
reason: 'Release recipes always run from ToT',
340343
);
341344
expect(
342345
request.gitilesCommit,

0 commit comments

Comments
 (0)