Skip to content

Commit 5baf04b

Browse files
committed
Store DateTime in millisecondsSinceEpoch
1 parent b9a228d commit 5baf04b

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

app_dart/lib/src/model/common/presubmit_completed_check.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ class PresubmitCompletedJob {
103103
stage: userData.stage,
104104
prNum: userData.pullRequestNumber,
105105
attempt: _getAttempt(build),
106-
startTime: build.startTime.toDateTime().microsecondsSinceEpoch,
107-
endTime: build.endTime.toDateTime().microsecondsSinceEpoch,
106+
startTime: build.startTime.toDateTime().millisecondsSinceEpoch,
107+
endTime: build.endTime.toDateTime().millisecondsSinceEpoch,
108108
summary: build.summaryMarkdown,
109109
buildNumber: build.number,
110110
);

app_dart/lib/src/model/common/presubmit_job_state.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ extension BuildToPresubmitJobState on bbv2.Build {
3737
jobName: builder.builder,
3838
status: status.toTaskStatus(),
3939
attemptNumber: BuildTags.fromStringPairs(tags).currentAttempt,
40-
startTime: startTime.toDateTime().microsecondsSinceEpoch,
41-
endTime: endTime.toDateTime().microsecondsSinceEpoch,
40+
startTime: startTime.toDateTime().millisecondsSinceEpoch,
41+
endTime: endTime.toDateTime().millisecondsSinceEpoch,
4242
summary: summaryMarkdown,
4343
buildNumber: number,
4444
);

app_dart/lib/src/service/firestore/unified_check_run.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ final class UnifiedCheckRun {
4646
// We store the creation time of the guard since there might be several
4747
// guards for the same PR created and each new one created after previous
4848
// was succeeded so we are interested in a state of the latest one.
49-
final creationTime = utcNow().microsecondsSinceEpoch;
49+
final creationTime = utcNow().millisecondsSinceEpoch;
5050
final guard = PresubmitGuard(
5151
checkRun: checkRun,
5252
headSha: sha,
@@ -124,7 +124,7 @@ final class UnifiedCheckRun {
124124
return null;
125125
}
126126

127-
final creationTime = utcNow().microsecondsSinceEpoch;
127+
final creationTime = utcNow().millisecondsSinceEpoch;
128128
final failedJobNames = latestGuard.failedJobNames;
129129
if (failedJobNames.isNotEmpty) {
130130
latestGuard.failedJobs = 0;
@@ -204,7 +204,7 @@ final class UnifiedCheckRun {
204204
return null;
205205
}
206206

207-
final creationTime = utcNow().microsecondsSinceEpoch;
207+
final creationTime = utcNow().millisecondsSinceEpoch;
208208
final jobs = guard.jobs;
209209
final currentStatus = jobs[jobName]!;
210210

packages/cocoon_common/lib/src/rpc_model/presubmit_guard_summary.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ final class PresubmitGuardSummary {
2222
/// The commit head SHA.
2323
final String headSha;
2424

25-
/// The creation timestamp in microseconds since epoch.
25+
/// The creation timestamp in milliseconds since epoch.
2626
final int creationTime;
2727

2828
/// The status of the guard.

0 commit comments

Comments
 (0)