fix: use correct issue link on flaky suppression (#4980)

- bonus: update melos script to fetch all (including no-pub workspace)
dart packages

fixes: flutter/flutter#183518

Author: jtmcdole

app_dart/lib/src/request_handlers/file_flaky_issue_and_pr.dart

@@ -159,6 +159,7 @@ final class FileFlakyIssueAndPR extends ApiRequestHandler {
       testName: builderDetail.statistic.name,
       email: 'fluttergithubbot',
       repository: slug,
+      issueLink: issue.htmlUrl,
       action: SuppressingAction.suppress,
       note: 'flaky test rate: $threshold',
     );

app_dart/lib/src/service/test_suppression.dart

@@ -102,7 +102,9 @@ class TestSuppression {
       final newSuppression = SuppressedTest(
         name: testName,
         repository: repository.fullName,
-        issueLink: issueLink ?? 'BUG',
+        issueLink:
+            issueLink ??
+            'BUG: You have found a bug! Please report to https://www.github.com/flutter/flutter/issues/new',
         isSuppressed: true,
         createTimestamp: now,
         updates: [updateEntry],

app_dart/test/request_handlers/file_flaky_issue_and_pr_test.dart

@@ -229,6 +229,7 @@ void main() {
               .hasTestName('Mac_android android_semantics_integration_test')
               .hasRepository('flutter/flutter')
               .hasIsSuppressed(isTrue)
+              .hasIssueLink(expectedSemanticsIntegrationTestNewIssueURL)
               .hasUpdates([
                 {
                   'user': 'fluttergithubbot',
@@ -395,6 +396,10 @@ void main() {
         );
         expect(suppressed.length, 1);
         expect(suppressed[0].testName, 'Linux analyze');
+        expect(
+          suppressed[0].issueLink,
+          expectedSemanticsIntegrationTestNewIssueURL,
+        );
 
         expect(result['Status'], 'success');
       },
@@ -435,6 +440,17 @@ void main() {
         final issueRequest = captured[1] as IssueRequest;
         expect(issueRequest.body, expectedLimitedNumberOfBuildsResponseBody);
 
+        // Verify suppression
+        final suppressed = await SuppressedTest.getSuppressedTests(
+          firestore,
+          'flutter/flutter',
+        );
+        expect(suppressed.length, 1);
+        expect(
+          suppressed[0].issueLink,
+          expectedSemanticsIntegrationTestNewIssueURL,
+        );
+
         expect(result['Status'], 'success');
       },
     );
@@ -482,6 +498,10 @@ void main() {
         'flutter/flutter',
       );
       expect(suppressed.length, 1);
+      expect(
+        suppressed[0].issueLink,
+        expectedSemanticsIntegrationTestNewIssueURL,
+      );
 
       expect(result['Status'], 'success');
     });

app_dart/test/request_handlers/update_suppressed_test_test.dart

@@ -378,6 +378,34 @@ void main() {
     );
     expect(isSuppressed, isFalse);
   });
+
+  test('TestSuppression uses default bug link if issueLink is null', () async {
+    final suppression = TestSuppression(
+      firestore: firestore,
+      cache: cache,
+      now: () => fakeNow,
+    );
+    await suppression.updateSuppression(
+      testName: 'my_test',
+      email: 'test@example.com',
+      repository: RepositorySlug('flutter', 'flutter'),
+      action: SuppressingAction.suppress,
+      note: 'test note',
+      issueLink: null,
+    );
+
+    // Verify document created with default bug link
+    expect(
+      firestore,
+      existsInStorage(SuppressedTest.metadata, [
+        isSuppressedTest
+            .hasIssueLink(
+              'BUG: You have found a bug! Please report to https://www.github.com/flutter/flutter/issues/new',
+            )
+            .hasTestName('my_test'),
+      ]),
+    );
+  });
 }
 
 class FakeGithubServiceWithIssue extends FakeGithubService {

pubspec.yaml

@@ -37,6 +37,13 @@ melos:
       dev_dependencies:
         test: any
   scripts:
+    # If you're using a worktree, this is helpful to remove missing package warnings
+    pub-get:
+      steps:
+        - flutter pub get
+        - cd cipd_packages/codesign; dart pub get
+        - cd ../device_doctor; dart pub get
+
     lint:all:
       steps:
         - analyze
@@ -57,11 +64,6 @@ melos:
       run: melos exec dart format . --set-exit-if-changed
       description: Run `dart format` checks for all packages.
 
-    pub-get:
-      steps:
-        - melos exec --no-flutter -- "dart pub get"
-        - melos exec --flutter -- "flutter pub get"
-
     upgrade: melos exec flutter pub upgrade
 
     test: