Skip to content

Commit a02c449

Browse files
authored
fix Re-run and Re-run failed issue (#5030)
fixed `Re-run` and `Re-run failed` issue finding PR by Merge Queue Guard Id Fix: flutter/flutter#185498
1 parent 383a09b commit a02c449

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

app_dart/lib/src/request_handlers/rerun_all_failed_jobs.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,11 @@ final class RerunAllFailedJobs extends ApiRequestHandler {
6565
pullRequest = await PrCheckRuns.findPullRequestFor(
6666
_firestore,
6767
guard.checkRunId,
68-
Config.kMergeQueueLockName,
68+
Config.kFlutterPresubmitsName,
6969
);
7070
} catch (e) {
7171
throw NotFoundException(
72-
'No pull request found for ${Config.kMergeQueueLockName} with ${guard.checkRunId} id',
72+
'No pull request found for ${Config.kFlutterPresubmitsName} with ${guard.checkRunId} id',
7373
);
7474
}
7575

app_dart/lib/src/request_handlers/rerun_failed_job.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,11 @@ final class RerunFailedJob extends ApiRequestHandler {
6767
pullRequest = await PrCheckRuns.findPullRequestFor(
6868
_firestore,
6969
guard.checkRunId,
70-
Config.kMergeQueueLockName,
70+
Config.kFlutterPresubmitsName,
7171
);
7272
} catch (e) {
7373
throw NotFoundException(
74-
'No pull request found for ${Config.kMergeQueueLockName} with ${guard.checkRunId} id',
74+
'No pull request found for ${Config.kFlutterPresubmitsName} with ${guard.checkRunId} id',
7575
);
7676
}
7777

app_dart/test/request_handlers/rerun_all_failed_jobs_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ void main() {
6767
firestoreService: firestore,
6868
pullRequest: pullRequest,
6969
checks: [
70-
generateCheckRun(guard.checkRunId, name: Config.kMergeQueueLockName),
70+
generateCheckRun(guard.checkRunId, name: Config.kFlutterPresubmitsName),
7171
],
7272
);
7373

@@ -139,7 +139,7 @@ void main() {
139139
firestoreService: firestore,
140140
pullRequest: pullRequest,
141141
checks: [
142-
generateCheckRun(guard.checkRunId, name: Config.kMergeQueueLockName),
142+
generateCheckRun(guard.checkRunId, name: Config.kFlutterPresubmitsName),
143143
],
144144
);
145145

@@ -190,7 +190,7 @@ void main() {
190190
firestoreService: firestore,
191191
pullRequest: pullRequest,
192192
checks: [
193-
generateCheckRun(guard.checkRunId, name: Config.kMergeQueueLockName),
193+
generateCheckRun(guard.checkRunId, name: Config.kFlutterPresubmitsName),
194194
],
195195
);
196196

app_dart/test/request_handlers/rerun_failed_job_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ void main() {
6767
firestoreService: firestore,
6868
pullRequest: pullRequest,
6969
checks: [
70-
generateCheckRun(guard.checkRunId, name: Config.kMergeQueueLockName),
70+
generateCheckRun(guard.checkRunId, name: Config.kFlutterPresubmitsName),
7171
],
7272
);
7373

@@ -140,7 +140,7 @@ void main() {
140140
firestoreService: firestore,
141141
pullRequest: pullRequest,
142142
checks: [
143-
generateCheckRun(guard.checkRunId, name: Config.kMergeQueueLockName),
143+
generateCheckRun(guard.checkRunId, name: Config.kFlutterPresubmitsName),
144144
],
145145
);
146146

@@ -214,7 +214,7 @@ void main() {
214214
firestoreService: firestore,
215215
pullRequest: pullRequest,
216216
checks: [
217-
generateCheckRun(guard.checkRunId, name: Config.kMergeQueueLockName),
217+
generateCheckRun(guard.checkRunId, name: Config.kFlutterPresubmitsName),
218218
],
219219
);
220220

0 commit comments

Comments
 (0)