Skip to content

Commit ad73c50

Browse files
authored
fix: add some logs to flaky handlers (#4978)
While testing today, I realized I can't see anything from the cloud logs.
1 parent d1fe9e4 commit ad73c50

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

app_dart/lib/src/request_handlers/file_flaky_issue_and_pr.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import 'dart:async';
66

7+
import 'package:cocoon_server/logging.dart';
78
import 'package:collection/collection.dart';
89
import 'package:github/github.dart';
910
import 'package:meta/meta.dart';
@@ -150,6 +151,9 @@ final class FileFlakyIssueAndPR extends ApiRequestHandler {
150151
slug: slug,
151152
threshold: threshold,
152153
);
154+
log.info(
155+
'FileFlakyIssueAndPR.fileIssueAndPR($slug): filed #${issue.number} for ${builderDetail.statistic.name} / ${builderDetail.statistic.flakyRate}',
156+
);
153157

154158
await _testSuppression.updateSuppression(
155159
testName: builderDetail.statistic.name,

app_dart/lib/src/request_handlers/update_existing_flaky_issues.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
import 'dart:async';
66

7+
import 'package:cocoon_server/logging.dart';
78
import 'package:github/github.dart';
89

910
import '../../ci_yaml.dart';
@@ -158,6 +159,11 @@ final class UpdateExistingFlakyIssue extends ApiRequestHandler {
158159
ignoreFlakyMap[target.name] = true;
159160
}
160161
}
162+
163+
log.info(
164+
'updateExistingFlakyIssue($slug): handling $nameToExistingIssue over ${builderFlakyMap.length} builders (${ignoreFlakyMap.length} ignored)',
165+
);
166+
161167
// Update an existing flaky bug with only prod stats if the builder is with `bringup: false`, such as a shard builder.
162168
//
163169
// Update an existing flaky bug with both prod and staging stats if the builder is with `bringup: true`. When a builder

0 commit comments

Comments
 (0)