Do not try to rerun experimental branch task failures. (#4677)

Towards flutter/flutter#168738.

This keeps task utilization of `ios-experimental` lower. More work is required to make this work e2e.

/cc @vashworth

Author: matanlurey

app_dart/lib/src/request_handlers/postsubmit_luci_subscription.dart

@@ -6,6 +6,7 @@ import 'dart:convert';
 import 'dart:io';
 
 import 'package:buildbucket/buildbucket_pb.dart' as bbv2;
+import 'package:cocoon_common/is_release_branch.dart';
 import 'package:cocoon_server/logging.dart';
 import 'package:googleapis/firestore/v1.dart' hide Status;
 
@@ -15,6 +16,7 @@ import '../model/firestore/task.dart' as fs;
 import '../request_handling/request_handler.dart';
 import '../request_handling/response.dart';
 import '../request_handling/subscription_handler.dart';
+import '../service/config.dart';
 import '../service/firestore.dart';
 import '../service/github_checks_service.dart';
 import '../service/luci_build_service.dart';
@@ -185,6 +187,14 @@ final class PostsubmitLuciSubscription extends SubscriptionHandler {
       _firestore,
       sha: task.commitSha,
     );
+    if (currentCommit.branch != Config.defaultBranch(currentCommit.slug) &&
+        !isReleaseCandidateBranch(branchName: currentCommit.branch)) {
+      log.info(
+        'Skip automatic reruns for experimental branch ${currentCommit.branch}',
+      );
+      return false;
+    }
+
     final commitList = await _firestore.queryRecentCommits(
       limit: 1,
       slug: currentCommit.slug,

app_dart/test/request_handlers/postsubmit_luci_subscription_test.dart

@@ -4,6 +4,8 @@
 
 import 'package:buildbucket/buildbucket_pb.dart' as bbv2;
 import 'package:cocoon_common/task_status.dart';
+import 'package:cocoon_common_test/cocoon_common_test.dart';
+import 'package:cocoon_server/logging.dart';
 import 'package:cocoon_server_test/test_logging.dart';
 import 'package:cocoon_service/cocoon_service.dart';
 import 'package:cocoon_service/src/model/firestore/task.dart' as fs;
@@ -611,6 +613,13 @@ void main() {
     await tester.post(handler);
 
     expect(firestore, existsInStorage(fs.Task.metadata, hasLength(1)));
+
+    expect(
+      log,
+      bufferedLoggerOf(
+        contains(logThat(message: contains('Max retries reached'))),
+      ),
+    );
   });
 
   test('skips rerunning when builder is not in tip-of-tree', () async {
@@ -647,5 +656,60 @@ void main() {
     await tester.post(handler);
 
     expect(firestore, existsInStorage(fs.Task.metadata, hasLength(1)));
+
+    expect(
+      log,
+      bufferedLoggerOf(contains(logThat(message: contains('Not tip of tree')))),
+    );
+  });
+
+  // Regression test for https://github.com/flutter/flutter/issues/168738.
+  test('skips rerunning when builder is an experimental branch', () async {
+    final fsCommit = generateFirestoreCommit(
+      1,
+      sha: '87f88734747805589f2131753620d61b22922822',
+      // Notably not "master" or "flutter-X.XX-candidate.0".
+      branch: 'ios-experimental',
+    );
+    final fsTask = generateFirestoreTask(
+      1,
+      name: 'Linux A',
+      commitSha: fsCommit.sha,
+      status: TaskStatus.inProgress,
+    );
+    firestore.putDocument(fsCommit);
+    firestore.putDocument(fsTask);
+
+    // Add another commit to ToT.
+    firestore.putDocument(generateFirestoreCommit(2));
+
+    tester.message = createPushMessage(
+      Int64(1),
+      status: bbv2.Status.FAILURE,
+      builder: 'Linux A',
+      userData: PostsubmitUserData(
+        checkRunId: null,
+        taskId: fs.TaskId(
+          commitSha: fsCommit.sha,
+          taskName: fsTask.taskName,
+          currentAttempt: fsTask.currentAttempt,
+        ),
+      ),
+    );
+
+    await tester.post(handler);
+
+    expect(firestore, existsInStorage(fs.Task.metadata, hasLength(1)));
+
+    expect(
+      log,
+      bufferedLoggerOf(
+        contains(
+          logThat(
+            message: contains('Skip automatic reruns for experimental branch'),
+          ),
+        ),
+      ),
+    );
   });
 }