Disable toggle suppression until update call completes (#4981)

Closes flutter/flutter#182386.

Author: matanlurey

dashboard/lib/widgets/test_details_popover.dart

@@ -36,6 +36,8 @@ class _TestDetailsPopoverState extends State<TestDetailsPopover> {
     );
   }
 
+  bool _isPendingUpdate = false;
+
   @override
   Widget build(BuildContext context) {
     final suppressed = suppressedTest;
@@ -61,7 +63,9 @@ class _TestDetailsPopoverState extends State<TestDetailsPopover> {
                   style: TextStyle(fontStyle: FontStyle.italic),
                 ),
                 (true, null) => ElevatedButton.icon(
-                  onPressed: () => _showSuppressDialog(context),
+                  onPressed: _isPendingUpdate
+                      ? null
+                      : () => _showSuppressDialog(context),
                   icon: const Icon(Icons.do_not_disturb_on_outlined),
                   label: const Text('Unblock Tree'),
                   style: ElevatedButton.styleFrom(
@@ -70,7 +74,9 @@ class _TestDetailsPopoverState extends State<TestDetailsPopover> {
                   ),
                 ),
                 (true, _) => ElevatedButton.icon(
-                  onPressed: () => _toggleSuppression(false),
+                  onPressed: _isPendingUpdate
+                      ? null
+                      : () => _toggleSuppression(false),
                   icon: const Icon(Icons.check_circle_outline),
                   label: const Text('Remove Suppression'),
                   style: ElevatedButton.styleFrom(
@@ -236,12 +242,18 @@ class _TestDetailsPopoverState extends State<TestDetailsPopover> {
     String? issueLink,
     String? note,
   }) async {
+    setState(() {
+      _isPendingUpdate = true;
+    });
     final success = await widget.buildState.updateTestSuppression(
       testName: widget.qualifiedTask.task,
       suppress: suppress,
       issueLink: issueLink,
       note: note,
     );
+    setState(() {
+      _isPendingUpdate = false;
+    });
     if (!success) {
       widget.showSnackBarCallback(
         const SnackBar(content: Text('Failed to update test suppression')),

dashboard/test/utils/fake_build.dart

@@ -122,6 +122,9 @@ class FakeBuildState extends ChangeNotifier implements BuildState {
 
   bool updateTestSuppressionResult = true;
 
+  /// If non-null, [updateTestSuppression] waits until this future completes.
+  Future<void>? pauseUpdateUntilCompleted;
+
   @override
   Future<bool> updateTestSuppression({
     required String testName,
@@ -135,6 +138,9 @@ class FakeBuildState extends ChangeNotifier implements BuildState {
       issueLink: issueLink,
       note: note,
     ));
+    if (pauseUpdateUntilCompleted case final shouldPause?) {
+      await shouldPause;
+    }
     return updateTestSuppressionResult;
   }
 }

dashboard/test/widgets/test_details_popover_test.dart

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'dart:async';
+
 import 'package:cocoon_common/rpc_model.dart';
 import 'package:cocoon_common/task_status.dart';
 import 'package:flutter/material.dart';
@@ -212,6 +214,55 @@ void main() {
       expect(call.issueLink, 'https://github.com/flutter/flutter/issues/1234');
       expect(call.note, 'Flaky test');
     });
+
+    testWidgets('disables toggle suppression while pending', (
+      WidgetTester tester,
+    ) async {
+      final waitUntil = Completer<void>();
+      buildState.pauseUpdateUntilCompleted = waitUntil.future;
+      buildState.updateTestSuppressionResult = true;
+      buildState.suppressedTests = [suppressedTest];
+
+      await tester.pumpWidget(
+        MaterialApp(
+          home: Scaffold(
+            body: TestDetailsPopover(
+              qualifiedTask: task,
+              buildState: buildState,
+              showSnackBarCallback: (SnackBar snackBar) {
+                ScaffoldMessenger.of(
+                  tester.element(find.byType(Scaffold)),
+                ).showSnackBar(snackBar);
+              },
+              closeCallback: () {},
+            ),
+          ),
+        ),
+      );
+
+      // Tap Remove Suppression
+      final findButton = find.text('Remove Suppression');
+
+      await tester.tap(findButton);
+      await tester.pump(); // Start async call
+      await tester.pump(); // Resolve async call and show snackbar
+      expect(
+        find.byWidgetPredicate(
+          (w) => w is ElevatedButton && w.onPressed == null,
+        ),
+        findsOneWidget,
+      );
+
+      waitUntil.complete();
+      await tester.pump();
+      expect(
+        find.byWidgetPredicate(
+          (w) => w is ElevatedButton && w.onPressed != null,
+        ),
+        findsOneWidget,
+      );
+    });
+
     testWidgets('shows error snackbar when update fails', (
       WidgetTester tester,
     ) async {