Skip to content

feat: diff the configs and output them#4680

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jtmcdole:diffConfigs
May 13, 2025
Merged

feat: diff the configs and output them#4680
auto-submit[bot] merged 2 commits into
flutter:mainfrom
jtmcdole:diffConfigs

Conversation

@jtmcdole
Copy link
Copy Markdown
Member

Side effect: don't set them if they aren't changing... shouldn't really be a side effect since we're single threaded.

@jtmcdole jtmcdole requested a review from matanlurey May 13, 2025 23:14
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label May 13, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label May 13, 2025
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented May 13, 2025

autosubmit label was removed for flutter/cocoon/4680, because - The status or check suite test-app-dart has failed. Please fix the issues identified (or deflake) before re-applying this label.

jtmcdole added 2 commits May 13, 2025 16:18
Side effect: don't set them if they aren't changing... shouldn't really
be a side effect since we're single threaded.
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label May 13, 2025
Copy link
Copy Markdown
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit Bot merged commit 99e66c5 into flutter:main May 13, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants