Skip to content

Add a log statement when a dart-internal re-run occurs but won't succeed. #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
May 16, 2025
Merged

Add a log statement when a dart-internal re-run occurs but won't succeed. #4690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app_dart/lib/src/request_handlers/rerun_prod_task.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,10 @@ final class RerunProdTask extends ApiRequestHandler {
// waiting for the task to be complete, we'd need a different strategy
// (i.e. multiple tasks per release builder, versus one).
if (!task.status.isComplete) {
log.info(
'Refused to re-run "${task.taskName}" (status: ${task.status}) - '
'attempt ${task.currentAttempt} already in progress',
);
throw const BadRequestException(
'Cannot rerun a release builder that is not done running',
);
Expand Down