Simplify Target.isReleaseBuild, with otherwise the same output.#4709
Merged
auto-submit[bot] merged 1 commit intoMay 19, 2025
Merged
Conversation
Note that there is a pre-step that already converts the string "true" to the boolean true, which is confusing, but go figure.
jtmcdole
approved these changes
May 19, 2025
Member
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
I added the "parse doubles" to that code as well :)
matanlurey
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that in
getProperties()there is a pre-step that already converts the string"true"to the booleantrue, which is confusing, but go figure.