Skip to content

Simplify Target.isReleaseBuild, with otherwise the same output. #4709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
May 19, 2025
Merged

Simplify Target.isReleaseBuild, with otherwise the same output. #4709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions app_dart/lib/src/model/ci_yaml/target.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,9 @@ final class Target {
return null;
}

/// Whether this target was marked with `release_build: true` in `.ci.yaml`.
/// Whether this target was marked with `properties: release_build: "true"`.
bool get isReleaseBuild {
final properties = getProperties();
return properties.containsKey('release_build') &&
(properties['release_build'] as bool);
return getProperties()['release_build'] == true;
}

/// Whether this target was marked with `bringup: true` in `.ci.yaml`.
Expand Down