Add and use a TimeRange class to represent before/after timestamp.#4719
Merged
auto-submit[bot] merged 1 commit intoMay 22, 2025
Merged
Conversation
jtmcdole
reviewed
May 21, 2025
jtmcdole
approved these changes
May 21, 2025
Member
jtmcdole
left a comment
jtmcdole
left a comment
There was a problem hiding this comment.
Looked at the code and you are filtering, so it looks like a nice adapter on top.
| factory TimeRange.between( | ||
| DateTime start, // | ||
| DateTime end, { | ||
| bool exclusive, |
Member
There was a problem hiding this comment.
Is this either:
(start, end) or [start, end]
and never (start, end] or [start, end)
matanlurey
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started to work on flutter/flutter#169234 and realized the current way timestamp filtering is done with Firebase is inflexible (and personally, confusing). This adds a small-ish
TimeRangeclass incocoon_commonsand uses it instead ofint? timestampto determine which commits to find.(Even if we want a different approach than flutter/flutter#169234, this seems worth it?)