Skip to content

Fix backfill execution based on ToT target comparison.#4723

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
matanlurey:fix-backfill-execution-based-on-tot
May 27, 2025
Merged

Fix backfill execution based on ToT target comparison.#4723
auto-submit[bot] merged 1 commit into
flutter:mainfrom
matanlurey:fix-backfill-execution-based-on-tot

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Closes flutter/flutter#169405.

  • Properly downloads (and compares) both the current commit .ci.yaml and the ToT .ci.yaml
  • A missing target is not an error, it just implicitly disables (skips) the target at the current commit
  • Adds tests for both skipping tasks properly and for the right properties: ... to be used as a system result

/cc @gmackall

@matanlurey matanlurey requested a review from jtmcdole May 25, 2025 15:40

@jtmcdole jtmcdole left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

required Iterable<Target> postsubmitTargets,
}) {
final totTargetsByName = {for (final t in tipOfTreeTargets) t.name: t};
final totTargetsByName = {for (final t in postsubmitTargets) t.name: t};

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/totTargetsByName/postTargetsByName/

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App. label May 27, 2025
@auto-submit auto-submit Bot merged commit 5f244d9 into flutter:main May 27, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.32 (hotfix) branch appears unhealthy after #169289

2 participants