Add a server flag onlyUseTipOfTreeTargetsExistenceToFilterTargets.#4731
Closed
matanlurey wants to merge 2 commits into
Closed
Add a server flag onlyUseTipOfTreeTargetsExistenceToFilterTargets.#4731matanlurey wants to merge 2 commits into
onlyUseTipOfTreeTargetsExistenceToFilterTargets.#4731matanlurey wants to merge 2 commits into
Conversation
jtmcdole
requested changes
May 28, 2025
Comment on lines
525
to
+533
|
|
||
| /// Whether to _only_ use the existence of a target at tip-of-tree to filter | ||
| /// out targets on other branches. | ||
| /// | ||
| /// See [CiYaml.onlyUseTipOfTreeTargetsExistenceToFilterTargets]. | ||
| @JsonKey( | ||
| defaultValue: Config.kOnlyUseTipOfTreeTargetsExistenceToFilterTargets, | ||
| ) | ||
| final bool onlyUseTipOfTreeTargetsExistenceToFilterTargets; |
Member
There was a problem hiding this comment.
I can see us having some other flags for ci_yaml; can we create a CiYamlFlags like ContentAwareHashingJson instead of expanding this?
| required this.slug, | ||
| required this.branch, | ||
| required Map<CiType, pb.SchedulerConfig> yamls, | ||
| bool onlyUseTipOfTreeTargetsExistenceToFilterTargets = |
Member
There was a problem hiding this comment.
Could we make this required without reaching out to Config.kOnlyUseTipOfTreeTargetsExistenceToFilterTargets?
Comment on lines
+46
to
+47
| /// See [CiYaml.onlyUseTipOfTreeTargetsExistenceToFilterTargets]. | ||
| static const bool kOnlyUseTipOfTreeTargetsExistenceToFilterTargets = false; |
Member
There was a problem hiding this comment.
Rather than exposing the default and maybe hiding places that do not pass this flag (error prone); make people refer to config.onlyUseTipOfTreeTargetsExistenceToFilterTargets.
Comment on lines
7
to
+8
|
|
||
| onlyUseTipOfTreeTargetsExistenceToFilterTargets: true |
Member
There was a problem hiding this comment.
do this in its own PR so it can be reverted cleanly if needed.
| /// | ||
| /// See [CiYaml.onlyUseTipOfTreeTargetsExistenceToFilterTargets]. | ||
| @JsonKey( | ||
| defaultValue: Config.kOnlyUseTipOfTreeTargetsExistenceToFilterTargets, |
Member
There was a problem hiding this comment.
default this to true as that's the current/safe option. The flag should get flipped in another PR and then eventually cleaned up in the future.
auto-submit Bot
pushed a commit
that referenced
this pull request
May 29, 2025
…#4732) Doing as pre-work before requested changes on #4731. I ran into a number of cases where changes were needed, and figured a separate PR was cleaner: - Moved all of the bits out of `config.dart` and into `flags/_*.dart` files to reduce file size - We have command-line tools in `app_dart/bin` that are _not_ a server (i.e. `verify_test_ownership.dart`) that create `CiYaml` objects, and also need `CiYamlFlags`. Instead of hacking something together, I added `DynamicConfig.fromRemoteLatest` and `DynamicConfig.fromLocalRepo` to use, respectively, in these command-line tools (which are used in CI production, not unused tools). - I made all of the objects `const`-able, and made it easy to create defaults, even if they are not `const` themselves, by using the `factory` constructor pattern. That also gets rid of the kludge we had with `contentAwareHashing` default values.
auto-submit Bot
pushed a commit
that referenced
this pull request
May 29, 2025
Closes #4731 (well, replaces). Towards flutter/flutter#169625.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards flutter/flutter#169625.