fixed LUCI BUILD log url for presubmit#4977
Merged
Merged
Conversation
Contributor
|
🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This PR correctly implements the separation of presubmit and postsubmit build log URLs by introducing generatePreSubmitBuildLogUrl and generatePostSubmitBuildLogUrl. It effectively updates all associated documentation and dashboard references.
🔍 General Feedback
- The refactoring into an enum
BuildersGroupis a clean and maintainable approach for differentiating builder environments. - A minor find-and-replace typo in an archive plan document was caught and suggested for a revert.
- Please ensure that unit tests are added for the newly introduced
generatePreSubmitBuildLogUrlfunction to maintain code coverage and correctness.
jtmcdole
approved these changes
Mar 9, 2026
ievdokdm
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed LUCI BUILD log url for presubmit
Updated api path in docs and comments
Fix: flutter/flutter#183345