fix: add some logs to flaky handlers#4978
Merged
Merged
Conversation
While testing today, I realized I can't see anything from the cloud logs.
Contributor
|
🤖 Hi @jtmcdole, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Contributor
There was a problem hiding this comment.
This PR introduces helpful logging to the flaky test handling mechanisms to improve observability. The additions are targeted and achieve the stated objective.
🔍 General Feedback
- The log additions are clear and context-rich.
- Consider avoiding logging full objects like the
Issueclass within collections to prevent excessive log bloat, as suggested in the inline comment.
Comment on lines
+163
to
+164
| log.info( | ||
| 'updateExistingFlakyIssue($slug): handling $nameToExistingIssue over ${builderFlakyMap.length} builders (${ignoreFlakyMap.length} ignored)', |
Contributor
There was a problem hiding this comment.
🟡 Logging the entire `nameToExistingIssue` map, which contains `Issue` objects as values, may result in verbose and hard-to-read logs since it will print the `toString()` representation of each `Issue`. Consider logging just the keys (builder names) or the total count to keep the logs clean and informative.
Suggested change
| log.info( | |
| 'updateExistingFlakyIssue($slug): handling $nameToExistingIssue over ${builderFlakyMap.length} builders (${ignoreFlakyMap.length} ignored)', | |
| log.info( | |
| 'updateExistingFlakyIssue($slug): handling ${nameToExistingIssue.keys} over ${builderFlakyMap.length} builders (${ignoreFlakyMap.length} ignored)', | |
| ); |
matanlurey
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing today, I realized I can't see anything from the cloud logs.