fix: add cicd label for autorollers#4984
Merged
Merged
Conversation
fixes #183617
Contributor
|
🤖 Hi @jtmcdole, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This Pull Request introduces functionality to automatically apply the CICD label to pull requests created by auto-roller accounts upon opened and edited webhook events. The overall logic is clear, well-placed, and includes updated tests to verify the new behavior correctly.
🔍 General Feedback
- Testing: Good job updating the webhook subscription tests to cover the new labeling logic for the configured auto-roller accounts.
- Readability: The extraction of the logic into a dedicated
_addCICDForRollershelper method keeps the main event switch block clean and maintainable. - Edge cases: Consider checking if the label is already present before applying it to prevent redundant API calls, especially since the logic runs on every
editedevent.
jtmcdole
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/cocoon/4984, Failed to merge flutter/cocoon/4984 with Pull request flutter/cocoon/4984 could not be merged: Required status check "ci.yaml validation" is expected.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #183617