fix: poll for provenance before deploying#4987
Merged
Merged
Conversation
This adds a delay of up to 2 minutes for the docker image to be ready. fixes: flutter/flutter#183787
Contributor
|
🤖 Hi @jtmcdole, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This Pull Request successfully introduces a polling mechanism to verify the availability of build provenance before deploying the Docker images. The logic is sound, utilizing a sensible retry and timeout approach to handle potential delays in provenance indexing.
🔍 General Feedback
- The polling implementation effectively ensures that subsequent deployment steps won't fail due to missing provenance data.
- The 2-minute timeout period with 10-second intervals is well-balanced for this type of operation.
- Please address the minor typographical errors in the comments to maintain clarity.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ievdokdm
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a delay of up to 2 minutes for the docker image to be ready.
fixes: flutter/flutter#183787