Fix merge group not closing on Neutral status#4990
Merged
Conversation
Contributor
|
🤖 Hi @jtmcdole, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This PR addresses the issue with the merge group not closing on a Neutral status by correctly mapping neutral outcomes to a new TaskStatus.neutral value. However, the addition of a new enum value without accompanying updates to exhaustive switch statements will break the Dart build across the repository.
🔍 General Feedback
- The logic updates in
presubmit_luci_subscription.dartand its associated tests are sound and correctly pass the neutral override status to the scheduler. - Ensure that the new
TaskStatus.neutralis correctly supported by all boolean getters (e.g.,isComplete,isSuccess) intask_status.dartto avoid unexpected hangs in task processing loops. - Please verify that all exhaustive switch statements across
dashboardandapp_dartare updated to handle the newTaskStatus.neutralvalue to fix the upcoming compilation errors.
jtmcdole
force-pushed
the
fixMergeGroupNotClosing
branch
from
3e90fad to
d67e77b
Compare
jtmcdole
added
CICD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A neutral "status" is completed and treated as successful in the case of testing
Follow up PR to refactor more of this + more tests.