cleanup: dart 3.10, dot shorthands, refactor isSuccess#4991
Merged
Conversation
- update to dart 3.10 - use dot shorthands in some places - refactor "status" maps to work.
Contributor
|
🤖 Hi @jtmcdole, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Member
Author
|
There is definitely more places we can update / cleanup. I'll probably write a task to do it. |
Contributor
There was a problem hiding this comment.
This pull request successfully refactors TaskStatus and TaskConclusion states to consolidate checks for success, completion, and failure statuses while bringing in Dart 3.10 features. However, several critical compile-time errors have been identified where dot shorthand (.enumValue) is improperly used in combination with the equality (== and !=) operators.
🔍 General Feedback
- Dot Shorthand Limitations: The
==and!=operators in Dart take anObjectas a parameter. Because of this, they do not provide an expected context type to the right-hand side operand, rendering dot shorthand invalid and causing compile-time errors. - Enum Lexical Scope: As a general rule when working within an
enumblock, its constants are already available in lexical scope, so you can just useconstantNamewithout qualification or dot shorthand (e.g.,successinstead of.successorTaskConclusion.success). - Use Switch Expressions: The refactoring to use
switch (this)for boolean status getters (likeisSuccessandisFailure) is clean, idiomatic Dart 3 code that leverages pattern matching. Where applicable,switchblocks provide the required context type that makes dot shorthand perfectly valid and should be used instead of chained equality checks.
ievdokdm
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of things: