Skip to content

Store DateTime in millisecondsSinceEpoch #5014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Apr 2, 2026
Merged

Store DateTime in millisecondsSinceEpoch #5014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app_dart/lib/src/model/common/presubmit_completed_check.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ class PresubmitCompletedJob {
stage: userData.stage,
prNum: userData.pullRequestNumber,
attempt: _getAttempt(build),
startTime: build.startTime.toDateTime().microsecondsSinceEpoch,
endTime: build.endTime.toDateTime().microsecondsSinceEpoch,
startTime: build.startTime.toDateTime().millisecondsSinceEpoch,
endTime: build.endTime.toDateTime().millisecondsSinceEpoch,
summary: build.summaryMarkdown,
buildNumber: build.number,
);
Expand Down
4 changes: 2 additions & 2 deletions app_dart/lib/src/model/common/presubmit_job_state.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ extension BuildToPresubmitJobState on bbv2.Build {
jobName: builder.builder,
status: status.toTaskStatus(),
attemptNumber: BuildTags.fromStringPairs(tags).currentAttempt,
startTime: startTime.toDateTime().microsecondsSinceEpoch,
endTime: endTime.toDateTime().microsecondsSinceEpoch,
startTime: startTime.toDateTime().millisecondsSinceEpoch,
endTime: endTime.toDateTime().millisecondsSinceEpoch,
summary: summaryMarkdown,
buildNumber: number,
);
Expand Down
6 changes: 3 additions & 3 deletions app_dart/lib/src/service/firestore/unified_check_run.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ final class UnifiedCheckRun {
// We store the creation time of the guard since there might be several
// guards for the same PR created and each new one created after previous
// was succeeded so we are interested in a state of the latest one.
final creationTime = utcNow().microsecondsSinceEpoch;
final creationTime = utcNow().millisecondsSinceEpoch;
final guard = PresubmitGuard(
checkRun: checkRun,
headSha: sha,
Expand Down Expand Up @@ -124,7 +124,7 @@ final class UnifiedCheckRun {
return null;
}

final creationTime = utcNow().microsecondsSinceEpoch;
final creationTime = utcNow().millisecondsSinceEpoch;
final failedJobNames = latestGuard.failedJobNames;
if (failedJobNames.isNotEmpty) {
latestGuard.failedJobs = 0;
Expand Down Expand Up @@ -204,7 +204,7 @@ final class UnifiedCheckRun {
return null;
}

final creationTime = utcNow().microsecondsSinceEpoch;
final creationTime = utcNow().millisecondsSinceEpoch;
final jobs = guard.jobs;
final currentStatus = jobs[jobName]!;

Expand Down
2 changes: 1 addition & 1 deletion packages/cocoon_common/lib/src/rpc_model/presubmit_guard_summary.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ final class PresubmitGuardSummary {
/// The commit head SHA.
final String headSha;

/// The creation timestamp in microseconds since epoch.
/// The creation timestamp in milliseconds since epoch.
final int creationTime;

/// The status of the guard.
Expand Down
Loading