Skip to content

Gracefully handle failure to acknowledge a pubsub message. #5015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Apr 3, 2026
Merged

Gracefully handle failure to acknowledge a pubsub message. #5015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d5d131
Gracefully handle failure to acknowledge a pubsub message.
eyebrowsoffire Apr 3, 2026
02e3f5f
Log with an error instead of a warning.
eyebrowsoffire Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions auto_submit/lib/request_handling/pubsub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,15 +59,21 @@ class PubSub {
///
/// The PubSub system can remove the relevant messages from the subscription.
Future<void> acknowledge(String subscription, String ackId) async {
final Client httpClient = await clientViaApplicationDefaultCredentials(
scopes: <String>[pubsub.PubsubApi.pubsubScope],
);
final pubsubApi = pubsub.PubsubApi(httpClient);
final ackIds = <String>[ackId];
final acknowledgeRequest = pubsub.AcknowledgeRequest(ackIds: ackIds);
await pubsubApi.projects.subscriptions.acknowledge(
acknowledgeRequest,
'${Config.pubsubSubscriptionsPrefix}/$subscription',
);
try {
final Client httpClient = await clientViaApplicationDefaultCredentials(
scopes: <String>[pubsub.PubsubApi.pubsubScope],
);
final pubsubApi = pubsub.PubsubApi(httpClient);
final ackIds = <String>[ackId];
final acknowledgeRequest = pubsub.AcknowledgeRequest(ackIds: ackIds);
await pubsubApi.projects.subscriptions.acknowledge(
acknowledgeRequest,
'${Config.pubsubSubscriptionsPrefix}/$subscription',
);
} catch (e) {
log.error(
'Failed to acknowledge message $ackId for subscription $subscription: $e',
);
}
}
}
19 changes: 19 additions & 0 deletions auto_submit/test/request_handling/pubsub_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Copyright 2026 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:auto_submit/request_handling/pubsub.dart';
import 'package:test/test.dart';

void main() {
group('PubSub', () {
test('acknowledge handles exceptions gracefully', () async {
const pubsub = PubSub();
// This should not throw even if credentials are missing or API fails.
await expectLater(
pubsub.acknowledge('test-sub', 'test-ack-id'),
completes,
);
});
});
}
Loading