default text if summary is null or empty#5016
Merged
auto-submit[bot] merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
ievdokdm
added
autosubmit
Contributor
|
🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This Pull Request addresses an issue where an empty summary (not null) in a presubmit job would be displayed as an empty box instead of default details. The fix correctly uses a null-aware and empty-check pattern to show default information in these cases.
🔍 General Feedback
- Robustness: While the fix correctly handles null and empty strings, consider using
trim().isEmptyto also handle cases where the summary consists only of whitespace characters. - Maintenance: A minor typo ('bellow' instead of 'below') was noted in the related
_getDefaultJobDetailsfunction's return strings, which should be corrected for better user experience. - Testing: Adding a test case for the empty string scenario would ensure the fix is robust and prevents future regressions.
Contributor
|
This pr possibly caused an auto submit regression. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: flutter/flutter#184360