Made it so dismissed approvals don't block the autosubmit bot.#5025
Made it so dismissed approvals don't block the autosubmit bot.#5025gaaclarke wants to merge 5 commits intoflutter:mainfrom
Conversation
The requirement is that you have approval, not that there is no requests changes. Dismissing requests changes should be used respectfully obviously. |
b-luk
left a comment
There was a problem hiding this comment.
This looks good to me, but I have no experience with this code or with how it works. So please also get approval from someone else who is more familiar with this.
| expect(result.result, isTrue); | ||
| }); | ||
|
|
||
| test('COMMENTED review should NOT clear previous CHANGES_REQUESTED', () async { |
There was a problem hiding this comment.
This is testing an impossible scenario, because our graphql query won't return a COMMENTED review. Maybe we can remove this test because it can be misleading.

fixes flutter/flutter#185224
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.