Skip to content

Made it so dismissed approvals don't block the autosubmit bot.#5025

Open
gaaclarke wants to merge 5 commits intoflutter:mainfrom
gaaclarke:dismiss-approval
Open

Made it so dismissed approvals don't block the autosubmit bot.#5025
gaaclarke wants to merge 5 commits intoflutter:mainfrom
gaaclarke:dismiss-approval

Conversation

@gaaclarke
Copy link
Copy Markdown
Member

fixes flutter/flutter#185224

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke added the CICD Run CI/CD label Apr 18, 2026
@gaaclarke gaaclarke requested review from b-luk and jtmcdole April 18, 2026 00:41
Comment thread auto_submit/lib/validations/approval.dart
@b-luk
Copy link
Copy Markdown

b-luk commented Apr 20, 2026

Also, not directly related to this change, but I notice that the UI lets me dismiss a REQUESTED_CHANGES review:
image

Does this mean that a REQUESTED_CHANGES review doesn't actually block an author from submitting, because they can always just dismiss that review? So REQUESTED_CHANGES is more of a suggestion than something that is enforceed?

Or is this UI something most people don't have, and I just see it because I have elevated permissions?

@gaaclarke
Copy link
Copy Markdown
Member Author

Does this mean that a REQUESTED_CHANGES review doesn't actually block an author from submitting, because they can always just dismiss that review? So REQUESTED_CHANGES is more of a suggestion than something that is enforceed?

The requirement is that you have approval, not that there is no requests changes. Dismissing requests changes should be used respectfully obviously.

@gaaclarke gaaclarke requested a review from b-luk April 21, 2026 16:57
Copy link
Copy Markdown

@b-luk b-luk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I have no experience with this code or with how it works. So please also get approval from someone else who is more familiar with this.

Comment thread auto_submit/lib/validations/approval.dart
expect(result.result, isTrue);
});

test('COMMENTED review should NOT clear previous CHANGES_REQUESTED', () async {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing an impossible scenario, because our graphql query won't return a COMMENTED review. Maybe we can remove this test because it can be misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autosubmit blocks merging on stale "request changes" pr

2 participants