Skip to content

[flutter-gold] Consider neutral checks completed#5036

Merged
jtmcdole merged 4 commits into
flutter:mainfrom
Piinks:goldNeutral
Apr 30, 2026
Merged

[flutter-gold] Consider neutral checks completed#5036
jtmcdole merged 4 commits into
flutter:mainfrom
Piinks:goldNeutral

Conversation

@Piinks
Copy link
Copy Markdown
Contributor

@Piinks Piinks commented Apr 30, 2026

Fixes flutter/flutter#185832

This PR improves how Flutter Gold status updates are computed by accounting for completed checks that end in a NEUTRAL conclusion (alongside SUCCESS). It also streamlines logging and fortifies the check status evaluation.

  • Updates the evaluation logic so that PR checks ending in NEUTRAL are no longer grouped alongside incomplete or failing tests.
  • Added explicit status verification for check runs. If a check run does not have the status 'COMPLETED', it is now safely and reliably classified as incomplete.
  • Moved the log.debug statement to only capture check runs that are truly incomplete or failing, significantly reducing log output noise.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Apr 30, 2026
@Piinks Piinks requested a review from jtmcdole April 30, 2026 16:37
Comment thread app_dart/lib/src/request_handlers/push_gold_status_to_github.dart Outdated
Comment thread app_dart/test/request_handlers/push_gold_status_to_github_test.dart
Co-authored-by: John "codefu" McDole <john@mcdole.org>
@Piinks Piinks requested a review from jtmcdole April 30, 2026 18:21
@jtmcdole jtmcdole added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 30, 2026
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 30, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Apr 30, 2026
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit Bot commented Apr 30, 2026

auto label is removed for flutter/cocoon/5036, Failed to merge flutter/cocoon/5036 with Pull request flutter/cocoon/5036 could not be merged: Required status check "ci.yaml validation" is expected..

@Piinks
Copy link
Copy Markdown
Contributor Author

Piinks commented Apr 30, 2026

Hmmm I can't rebase, it's already up to date. Not sure what is up with ci.yaml here

@jtmcdole jtmcdole added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App. and removed CICD Run CI/CD labels Apr 30, 2026
@jtmcdole jtmcdole merged commit 93db417 into flutter:main Apr 30, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App. CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skia gold check stuck

2 participants