[flutter-gold] Consider neutral checks completed#5036
Merged
Conversation
jtmcdole
requested changes
Apr 30, 2026
Co-authored-by: John "codefu" McDole <john@mcdole.org>
jtmcdole
approved these changes
Apr 30, 2026
Contributor
|
auto label is removed for flutter/cocoon/5036, Failed to merge flutter/cocoon/5036 with Pull request flutter/cocoon/5036 could not be merged: Required status check "ci.yaml validation" is expected.. |
Contributor
Author
|
Hmmm I can't rebase, it's already up to date. Not sure what is up with ci.yaml here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#185832
This PR improves how Flutter Gold status updates are computed by accounting for completed checks that end in a
NEUTRALconclusion (alongsideSUCCESS). It also streamlines logging and fortifies the check status evaluation.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.