Skip to content

Commit 03c168c

Browse files
committed
Remove unused code in extensions/ and framework/
1 parent 6d414f7 commit 03c168c

7 files changed

Lines changed: 8 additions & 9 deletions

File tree

analysis_options.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,6 @@ dart_code_metrics:
164164
# TODO(https://github.com/flutter/devtools/issues/9906) remove these
165165
# excludes as findings are resolved.
166166
- integration_test/**
167-
- lib/src/extensions/**
168-
- lib/src/framework/**
169167
- lib/src/screens/**
170168
- lib/src/service/**
171169
- lib/src/shared/**

packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ class EmbeddedExtensionControllerImpl extends EmbeddedExtensionController
7878
final extensionPostEventStream =
7979
StreamController<DevToolsExtensionEvent>.broadcast();
8080

81+
// ignore: unused-code, TODO(https://github.com/flutter/devtools/issues/9907): false positive.
8182
bool _initialized = false;
8283

8384
@override

packages/devtools_app/lib/src/extensions/embedded/_view_desktop.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ import 'package:flutter/material.dart';
77
import 'controller.dart';
88

99
class EmbeddedExtension extends StatelessWidget {
10-
const EmbeddedExtension({super.key, required this.controller});
11-
12-
final EmbeddedExtensionController controller;
10+
const EmbeddedExtension({
11+
super.key,
12+
required EmbeddedExtensionController controller,
13+
});
1314

1415
@override
1516
Widget build(BuildContext context) {

packages/devtools_app/lib/src/extensions/extension_service.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ class ExtensionService extends DisposableController
7070
///
7171
/// This set of extensions will include one version of a DevTools extension
7272
/// per package.
73+
@visibleForTesting
7374
List<DevToolsExtensionConfig> get availableExtensions =>
7475
_currentExtensions.value.availableExtensions;
7576

packages/devtools_app/lib/src/framework/home_screen.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ class HomeScreen extends Screen {
3232
titleGenerator: () => devToolsTitle.value,
3333
);
3434

35-
static final id = ScreenMetaData.home.id;
36-
3735
final List<DevToolsJsonFile> sampleData;
3836

3937
@override
@@ -171,6 +169,7 @@ class _ConnectInputState extends State<ConnectInput> with BlockingActionMixin {
171169
}());
172170
}
173171

172+
// ignore: unused-code, TODO(https://github.com/flutter/devtools/issues/9907): false positive.
174173
void _debugInitVmServiceCache() async {
175174
// We only do this in debug mode as it speeds iteration for DevTools
176175
// developers who tend to repeatedly restart DevTools to debug the same

packages/devtools_app/lib/src/framework/release_notes.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ bool debugTestReleaseNotes = false;
2828
// from the flutter/website PR, which has a GitHub action that automatically
2929
// stages commits to firebase. Example:
3030
// https://flutter-docs-prod--pr12652-devtools-release-notes-2-52-3bbb8c0u.web.app/tools/devtools/release-notes/release-notes-2.52.0.md.
31+
// ignore: unused-code, debug-only feature.
3132
String? _debugReleaseNotesUrl;
3233

3334
const releaseNotesKey = Key('release_notes');

packages/devtools_app/lib/src/framework/scaffold/status_line.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,6 @@ class StatusLine extends StatelessWidget {
3737
/// Whether to highlight the footer when DevTools is connected to an app.
3838
final bool highlightForConnection;
3939

40-
static const deviceInfoTooltip = 'Device Info';
41-
4240
/// The padding around the footer in the DevTools UI.
4341
EdgeInsets get padding => const EdgeInsets.symmetric(
4442
horizontal: defaultSpacing,

0 commit comments

Comments
 (0)