Skip to content

Commit 23d9d05

Browse files
committed
Fix formatting and add release note
1 parent e1c52f3 commit 23d9d05

2 files changed

Lines changed: 39 additions & 50 deletions

File tree

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ TODO: Remove this section if there are not any updates.
2424

2525
## Performance updates
2626

27-
TODO: Remove this section if there are not any updates.
27+
- Added a message in the Performance panel when widget rebuild tracking is
28+
unavailable because the app is running in profile mode. [#9755](https://github.com/flutter/devtools/pull/9755)
2829

2930
## CPU profiler updates
3031

@@ -40,14 +41,10 @@ TODO: Remove this section if there are not any updates.
4041

4142
## Network profiler updates
4243

43-
- Added response size column to the Network tab and displayed response size in the request inspector overview.
44+
- Added response size column to the Network tab and displayed response size in the request inspector overview.
4445
[#9744](https://github.com/flutter/devtools/pull/9744)
45-
4646
- Improved HTTP request status classification in the Network tab to better distinguish cancelled, completed, and in-flight requests (for example, avoiding some cases where cancelled requests appeared as pending). [#9683](https://github.com/flutter/devtools/pull/9683)
4747

48-
- Added a filter setting to hide HTTP-profiler socket data.
49-
[#9698](https://github.com/flutter/devtools/pull/9698)
50-
5148
## Logging updates
5249

5350
- Fixed an issue where log messages containing newline characters were incorrectly split into multiple separate entries in the Logging screen. [#9757](https://github.com/flutter/devtools/pull/9757)
@@ -75,4 +72,4 @@ TODO: Remove this section if there are not any updates.
7572
## Full commit history
7673

7774
To find a complete list of changes in this release, check out the
78-
[DevTools git log](https://github.com/flutter/devtools/tree/v2.58.0).
75+
[DevTools git log](https://github.com/flutter/devtools/tree/v2.58.0).

packages/devtools_app/test/screens/performance/performance_screen_test.dart

Lines changed: 35 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -379,55 +379,47 @@ void main() {
379379
selectedFrame = ValueNotifier<FlutterFrame?>(null);
380380
});
381381

382-
testWidgets(
383-
'shows message when running in profile mode',
384-
(WidgetTester tester) async {
385-
final app = fakeServiceConnection.serviceManager.connectedApp!;
386-
when(app.isProfileBuildNow).thenReturn(true);
387-
388-
await tester.pumpWidget(
389-
wrapWithControllers(
390-
RebuildStatsView(
391-
model: model,
392-
selectedFrame: selectedFrame,
393-
),
394-
),
395-
);
396-
await tester.pump();
382+
testWidgets('shows message when running in profile mode', (
383+
WidgetTester tester,
384+
) async {
385+
final app = fakeServiceConnection.serviceManager.connectedApp!;
386+
when(app.isProfileBuildNow).thenReturn(true);
397387

398-
expect(
399-
find.textContaining('Widget rebuild counts are only available'),
400-
findsOneWidget,
401-
);
402-
},
403-
);
388+
await tester.pumpWidget(
389+
wrapWithControllers(
390+
RebuildStatsView(model: model, selectedFrame: selectedFrame),
391+
),
392+
);
393+
await tester.pump();
404394

405-
testWidgets(
406-
'shows normal UI when running in debug mode',
407-
(WidgetTester tester) async {
408-
final app = fakeServiceConnection.serviceManager.connectedApp!;
409-
when(app.isProfileBuildNow).thenReturn(false);
410-
411-
await tester.pumpWidget(
412-
wrapWithControllers(
413-
RebuildStatsView(
414-
model: model,
415-
selectedFrame: selectedFrame,
416-
),
417-
),
418-
);
419-
await tester.pump();
395+
expect(
396+
find.textContaining('Widget rebuild counts are only available'),
397+
findsOneWidget,
398+
);
399+
});
420400

421-
expect(
422-
find.textContaining('Widget rebuild counts are only available'),
423-
findsNothing,
424-
);
425-
},
426-
);
401+
testWidgets('shows normal UI when running in debug mode', (
402+
WidgetTester tester,
403+
) async {
404+
final app = fakeServiceConnection.serviceManager.connectedApp!;
405+
when(app.isProfileBuildNow).thenReturn(false);
406+
407+
await tester.pumpWidget(
408+
wrapWithControllers(
409+
RebuildStatsView(model: model, selectedFrame: selectedFrame),
410+
),
411+
);
412+
await tester.pump();
413+
414+
expect(
415+
find.textContaining('Widget rebuild counts are only available'),
416+
findsNothing,
417+
);
418+
});
427419
});
428420
});
429421
}
430422

431423
Finder markdownFinder(String textMatch) => find.byWidgetPredicate(
432424
(widget) => widget is Markdown && widget.data.contains(textMatch),
433-
);
425+
);

0 commit comments

Comments
 (0)