Skip to content

Commit 2b9ad7e

Browse files
committed
Use EventKind.kTimerSignificantlyOverdue
1 parent 3c51868 commit 2b9ad7e

3 files changed

Lines changed: 5 additions & 4 deletions

File tree

flutter-candidate.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ead0a01bb9707b60097679a43a6262a8979f4a89
1+
09405e87d819691e787ae95cc7f4297338e5f6d2

packages/devtools_app/lib/src/screens/logging/metadata.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import 'package:devtools_app_shared/service.dart';
88
import 'package:devtools_app_shared/ui.dart';
99
import 'package:flutter/material.dart';
1010
import 'package:logging/logging.dart';
11+
import 'package:vm_service/vm_service.dart' show EventKind;
1112

1213
import '../../shared/primitives/utils.dart';
1314
import 'logging_controller.dart';
@@ -201,7 +202,7 @@ class KindMetaDataChip extends MetadataChip {
201202
String? kindIconAsset;
202203
if (kind == 'stdout' || kind == 'stderr') {
203204
kindIcon = Icons.terminal_rounded;
204-
} else if (kind == 'TimerSignificantlyOverdue') {
205+
} else if (kind == EventKind.kTimerSignificantlyOverdue) {
205206
kindIcon = Icons.timer_rounded;
206207
} else if (RegExp(r'^flutter\..*$').hasMatch(kind)) {
207208
kindIconAsset = 'icons/flutter.png';

packages/devtools_app/test/screens/logging/logging_controller_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@ void main() {
5151
void addTimerData(String message, {required IsolateRef isolateRef}) {
5252
controller.log(
5353
LogData(
54-
'TimerSignificantlyOverdue',
54+
EventKind.kTimerSignificantlyOverdue,
5555
jsonEncode({
56-
'kind': 'TimerSignificantlyOverdue',
56+
'kind': EventKind.kTimerSignificantlyOverdue,
5757
'details': message,
5858
'isolateRef': isolateRef.toJson(),
5959
}),

0 commit comments

Comments
 (0)