fix pretty print review comment

Author: kenzieschmoll

packages/devtools_app/benchmark/devtools_benchmarks_test.dart

@@ -92,7 +92,7 @@ Future<void> _runBenchmarks({bool useWasm = false}) async {
 
   stdout.writeln('Web benchmark tests finished.');
 
-  expect(taskResult.toJson().prettyPrint(), isA<String>());
+  expect(prettyPrintJson(taskResult.toJson()), isA<String>());
   expect(taskResult.scores.keys, hasLength(DevToolsBenchmark.values.length));
 
   for (final devToolsBenchmark in DevToolsBenchmark.values) {

packages/devtools_app/benchmark/scripts/compare_benchmarks.dart

@@ -62,6 +62,6 @@ void compareBenchmarks(
   stdout.writeln('Baseline comparison finished.');
   stdout
     ..writeln('==== Comparison with baseline $baselineSource ====')
-    ..writeln(delta.toJson().prettyPrint())
+    ..writeln(prettyPrintJson(delta.toJson()))
     ..writeln('==== End of baseline comparison ====');
 }

packages/devtools_app/lib/src/screens/debugger/span_parser.dart

@@ -69,12 +69,12 @@ class Grammar {
 
   @override
   String toString() {
-    return {
+    return prettyPrintJson({
       'name': name,
       'scopeName': scopeName,
       'topLevelMatcher': topLevelMatcher.toJson(),
       'repository': repository.toJson(),
-    }.prettyPrint();
+    });
   }
 }
 

packages/devtools_app/lib/src/screens/logging/logging_controller.dart

@@ -1038,8 +1038,7 @@ class LogData with SearchableDataMixin {
     }
 
     try {
-      return (jsonDecode(details!) as Object?)
-          .prettyPrint()
+      return prettyPrintJson(jsonDecode(details!) as Object?)
           .replaceAll(r'\n', '\n')
           .trim();
     } catch (_) {

packages/devtools_app/lib/src/shared/config_specific/framework_initialize/_framework_initialize_desktop.dart

@@ -37,7 +37,7 @@ class FlutterDesktopStorage implements Storage {
       File(_preferencesFile.path).createSync(recursive: true);
       _fileAndDirVerified = true;
     }
-    _preferencesFile.writeAsStringSync('${_values.prettyPrint()}\n');
+    _preferencesFile.writeAsStringSync('${prettyPrintJson(_values)}\n');
   }
 
   Map<String, Object?> _readValues() {

packages/devtools_app/lib/src/shared/primitives/utils.dart

@@ -212,10 +212,9 @@ class JsonUtils {
   }
 }
 
-/// Add pretty print for a JSON payload.
-extension JsonObjectExtension on Object? {
-  String prettyPrint() => const JsonEncoder.withIndent('  ').convert(this);
-}
+/// Returns a pretty-printed representation of a JSON payload.
+String prettyPrintJson(Object? json) =>
+    const JsonEncoder.withIndent('  ').convert(json);
 
 typedef RateLimiterCallback = Future<void> Function();
 

packages/devtools_app/lib/src/shared/ui/common_widgets.dart

@@ -1044,13 +1044,14 @@ class _JsonViewerState extends State<JsonViewer> {
   String copyJsonData(DartObjectNode copiedVariable) {
     // Check if service connection is active
     if (serviceConnection.serviceManager.connectedState.value.connected) {
-      return serviceConnection.serviceManager.service!.fakeServiceCache
-          .instanceToJson(copiedVariable.value as Instance)
-          .prettyPrint();
+      return prettyPrintJson(
+        serviceConnection.serviceManager.service!.fakeServiceCache
+          .instanceToJson(copiedVariable.value as Instance),
+      );
     }
 
     // Directly convert object to JSON if not connected
-    return copiedVariable.value.prettyPrint();
+    return prettyPrintJson(copiedVariable.value);
   }
 }