Skip to content

Commit 4257c47

Browse files
committed
Fix variable placement for response size rendering
1 parent 3c17534 commit 4257c47

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,7 @@ class NetworkRequestOverviewView extends StatelessWidget {
625625
}
626626

627627
List<Widget> _buildGeneralRows(BuildContext context) {
628+
final bytes = data.responseBytes;
628629
return [
629630
// TODO(kenz): show preview for requests (png, response body, proto)
630631
_buildRow(
@@ -662,7 +663,7 @@ class NetworkRequestOverviewView extends StatelessWidget {
662663
_buildRow(
663664
context: context,
664665
title: 'Response Size',
665-
child: _valueText(_formatBytes(data.responseBytes)),
666+
child: _valueText(bytes != null ? _formatBytes(bytes) : '-'),
666667
),
667668
const SizedBox(height: defaultSpacing),
668669

packages/devtools_app/lib/src/screens/network/network_screen.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,8 @@ class ResponseSizeColumn extends ColumnData<NetworkRequest> {
429429

430430
@override
431431
String getDisplayValue(NetworkRequest dataObject) {
432-
return _formatBytes(dataObject.responseBytes);
432+
final bytes = dataObject.responseBytes;
433+
return bytes != null ? _formatBytes(bytes) : '-';
433434
}
434435
}
435436

0 commit comments

Comments
 (0)