Skip to content

Commit 5122355

Browse files
authored
Update dart_skills_lint dependency to e449787 and inherit target configuration (#9830)
Updates the pinned `dart_skills_lint` reference in `tool/pubspec.yaml` to commit hash `e4497873950727ee781fa411c1a2f624b1ec50c6` (version `0.3.0`). Refactors `tool/test/validate_skills_test.dart` to load configuration dynamically via `ConfigParser.loadConfig` and omit targeting overrides, enabling native path inheritance from `tool/dart_skills_lint.yaml`. ### General checklist ### Issues checklist ### Tests checklist ### AI-tooling checklist * [x] I read the [AI contributions guidelines] and agree to follow them. * [x] I reviewed all AI-generated code before opening this PR. * [x] I understand and am able to discuss the code in this PR. * [x] I have verifed the accuracy of any AI-generated text included in the PR description. * [x] I commit to verifying the accuracy of any AI-generated code or text that I upload in response to review comments. ### Feature-change checklist * [x] I added the `release-notes-not-required` label or left a comment requesting the label be added.
1 parent adce730 commit 5122355

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

pubspec.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,11 +213,11 @@ packages:
213213
dependency: transitive
214214
description:
215215
path: "tool/dart_skills_lint"
216-
ref: "2420128e11101002e2eac98eb90512103a388714"
217-
resolved-ref: "2420128e11101002e2eac98eb90512103a388714"
216+
ref: e4497873950727ee781fa411c1a2f624b1ec50c6
217+
resolved-ref: e4497873950727ee781fa411c1a2f624b1ec50c6
218218
url: "https://github.com/flutter/skills"
219219
source: git
220-
version: "0.2.0"
220+
version: "0.3.0"
221221
dart_style:
222222
dependency: transitive
223223
description:

tool/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,6 @@ dev_dependencies:
2828
git:
2929
url: https://github.com/flutter/skills
3030
path: tool/dart_skills_lint
31-
ref: 2420128e11101002e2eac98eb90512103a388714
31+
ref: e4497873950727ee781fa411c1a2f624b1ec50c6
3232
logging: ^1.1.1
3333
test: ^1.25.8

tool/test/validate_skills_test.dart

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ import 'package:dart_skills_lint/dart_skills_lint.dart';
77
import 'package:logging/logging.dart';
88
import 'package:test/test.dart';
99

10+
const String _configFilePath = 'dart_skills_lint.yaml';
11+
1012
void main() {
1113
test('Validate DevTools Skills', () async {
1214
final Level oldLevel = Logger.root.level;
@@ -17,16 +19,10 @@ void main() {
1719
});
1820

1921
try {
20-
// TODO(https://github.com/flutter/skills/issues/85): Update test
21-
// to use dart_skills_lint.yaml for config when available.
22-
final bool isValid = await validateSkills(
23-
skillDirPaths: ['../.agents/skills'],
24-
resolvedRules: {
25-
'check-relative-paths': AnalysisSeverity.error,
26-
'check-absolute-paths': AnalysisSeverity.error,
27-
'check-trailing-whitespace': AnalysisSeverity.error,
28-
},
22+
final Configuration config = await ConfigParser.loadConfig(
23+
path: _configFilePath,
2924
);
25+
final bool isValid = await validateSkills(config: config);
3026
expect(
3127
isValid,
3228
isTrue,

0 commit comments

Comments
 (0)