Remove unused code from screens/

Author: kenzieschmoll

analysis_options.yaml

@@ -164,7 +164,8 @@ dart_code_metrics:
       # TODO(https://github.com/flutter/devtools/issues/9906) remove these
       # excludes as findings are resolved.
       - integration_test/**
-      - lib/src/screens/**
+      # Investigate internal usages of inspector_controller before removing.
+      - lib/src/screens/inspector/**_controller.dart
       - lib/src/service/**
       - lib/src/shared/**
       - lib/src/standalone_ui/**

packages/devtools_app/lib/src/screens/accessibility/accessibility_screen.dart

@@ -19,8 +19,6 @@ export 'semantics_tree_pane.dart';
 class AccessibilityScreen extends Screen {
   AccessibilityScreen() : super.fromMetaData(ScreenMetaData.accessibility);
 
-  static final id = ScreenMetaData.accessibility.id;
-
   @override
   Widget buildScreenBody(BuildContext context) =>
       const AccessibilityScreenBody();
@@ -36,11 +34,13 @@ class AccessibilityScreenBody extends StatefulWidget {
 
 class _AccessibilityScreenBodyState extends State<AccessibilityScreenBody>
     with AutoDisposeMixin {
+  // ignore: unused-code, temporarily ignore since this screen is under active development.   
   late AccessibilityController controller;
 
   @override
   void initState() {
     super.initState();
+    // ignore: unused-code, temporarily ignore since this screen is under active development.
     controller = screenControllers.lookup<AccessibilityController>();
   }
 

packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart

@@ -212,7 +212,6 @@ class _AppSizeBodyState extends State<AppSizeBody>
                   if (currentTab.key == AppSizeScreen.diffTabKey) ...[
                     const SizedBox(width: defaultSpacing),
                     DiffTreeTypeDropdown(
-                      value: controller.activeDiffTreeType.value,
                       onChanged: (newDiffTreeType) {
                         controller.changeActiveDiffTreeType(newDiffTreeType!);
                       },
@@ -279,11 +278,9 @@ class AppUnitDropdown extends StatelessWidget {
 class DiffTreeTypeDropdown extends StatelessWidget {
   const DiffTreeTypeDropdown({
     super.key,
-    required this.value,
     required this.onChanged,
   });
 
-  final DiffTreeType value;
   final ValueChanged<DiffTreeType?>? onChanged;
 
   @override

packages/devtools_app/lib/src/screens/debugger/breakpoint_manager.dart

@@ -23,7 +23,6 @@ class BreakpointManager with DisposerMixin {
 
   final _breakPositionsMap = <String, List<SourcePosition>>{};
 
-  ValueListenable<List<Breakpoint>> get breakpoints => _breakpoints;
   final _breakpoints = ValueNotifier<List<Breakpoint>>([]);
 
   ValueListenable<List<BreakpointAndSourcePosition>>

packages/devtools_app/lib/src/screens/debugger/codeview_controller.dart

@@ -533,6 +533,7 @@ class CodeViewSourceLocationNavigationState extends DevToolsNavigationState {
     DevToolsNavigationState state,
   ) : super(kind: type, state: state.state);
 
+  @visibleForTesting
   static CodeViewSourceLocationNavigationState? fromState(
     DevToolsNavigationState? state,
   ) {

packages/devtools_app/lib/src/screens/debugger/span_parser.dart

@@ -589,19 +589,6 @@ class ScopeStack {
   /// Location where the next produced span should begin.
   ScopeStackLocation _nextLocation = ScopeStackLocation.zero;
 
-  /// Adds a scope for a given region.
-  ///
-  /// This method is the same as calling [push] and then [pop] with the same
-  /// args.
-  void add(
-    String? scope, {
-    required ScopeStackLocation start,
-    required ScopeStackLocation end,
-  }) {
-    push(scope, start);
-    pop(scope, end);
-  }
-
   /// Pushes a new scope onto the stack starting at [location].
   void push(String? scope, ScopeStackLocation location) {
     if (scope == null) return;
@@ -721,6 +708,8 @@ class ScopeStackItem {
   ScopeStackItem(this.scope, this.location);
 
   final String scope;
+
+  // ignore: unused-code, foundational to this data class.
   final ScopeStackLocation location;
 }
 

packages/devtools_app/lib/src/screens/debugger/syntax_highlighter.dart

@@ -18,6 +18,7 @@ final _log = Logger('syntax_highlighter');
 class SyntaxHighlighter {
   SyntaxHighlighter({String? source}) : source = source ?? '';
 
+  @visibleForTesting
   SyntaxHighlighter.withGrammar({Grammar? grammar, String? source})
     : source = source ?? '' {
     _grammar = grammar;

packages/devtools_app/lib/src/screens/deep_link_validation/deep_link_list_view.dart

@@ -33,13 +33,12 @@ class DeepLinkListView extends StatefulWidget {
 }
 
 class _DeepLinkListViewState extends State<DeepLinkListView> {
-  late DeepLinksController controller;
-
   @override
   void initState() {
     super.initState();
-    controller = screenControllers.lookup<DeepLinksController>()
-      ..firstLoadWithDefaultConfigurations();
+    screenControllers
+        .lookup<DeepLinksController>()
+        .firstLoadWithDefaultConfigurations();
   }
 
   @override

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_model.dart

@@ -219,14 +219,6 @@ class AASAfileFormatSubCheck extends CommonError {
     ),
   );
 
-  static final defaultsCaseSensitiveFormat = AASAfileFormatSubCheck(
-    'Applinks defaults case sensitive format',
-    propertyTypeMessage(
-      property: 'applinks.defaults.caseSensitive',
-      expectedType: 'boolean',
-    ),
-  );
-
   static const detailsFormat = AASAfileFormatSubCheck(
     'Applinks details format',
     'This test checks that the `applinks.details` property is formatted properly. Ref - '
@@ -402,6 +394,7 @@ class Path {
   final String path;
 
   // TODO(hangyujin): display queryParams in path table.
+  // ignore: unused-code, outstanding TODO.
   final Map<String, String> queryParams;
 
   /// A Boolean value that indicates whether to stop pattern matching and prevent the universal

packages/devtools_app/lib/src/screens/deep_link_validation/deep_links_screen.dart

@@ -18,9 +18,8 @@ class DeepLinksScreen extends Screen {
 
   static final id = ScreenMetaData.deepLinks.id;
 
-  // TODO(https://github.com/flutter/devtools/issues/6013): write documentation.
-  // @override
-  // String get docPageId => id;
+  @override
+  String get docPageId => id;
 
   @override
   String get docsUrl => 'https://flutter.dev/to/deep-link-tool';