[Property Editor] Do not trigger edits if there have been no changes to a property (#8951)

Author: elliette

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart

@@ -214,6 +214,7 @@ class _TextInputState<T> extends State<_TextInput<T>>
   @override
   void initState() {
     super.initState();
+    _currentValue = widget.property.valueDisplay;
     _focusNode = FocusNode(debugLabel: 'text-input-${widget.property.name}');
 
     addAutoDisposeListener(_focusNode, () async {
@@ -270,6 +271,9 @@ mixin _PropertyInputMixin<T extends StatefulWidget, U> on State<T> {
     required EditArgumentFunction editPropertyCallback,
     required String? valueAsString,
   }) async {
+    // If no changes have been made to the property, don't send an edit request.
+    if (property.valueDisplay == valueAsString) return;
+
     clearServerError();
     final argName = property.name;
     ga.select(

packages/devtools_app/test/standalone_ui/ide_shared/property_editor/property_editor_test.dart

@@ -417,6 +417,30 @@ void main() {
       });
     });
 
+    testWidgets('editing a string input to its current value (title)', (
+      tester,
+    ) async {
+      return await tester.runAsync(() async {
+        // Load the property editor.
+        controller.initForTestsOnly(editableArgsResult: result1);
+        await tester.pumpWidget(wrap(propertyEditor));
+
+        // Edit the title.
+        final titleInput = _findTextFormField('title');
+        await _inputText(titleInput, text: 'Hello world!', tester: tester);
+
+        // Verify it doesn't trigger an edit.
+        try {
+          await nextEditCompleter.future.timeout(
+            const Duration(milliseconds: 100),
+          );
+          fail('nextEditCompleter was unexpectedly completed.');
+        } on TimeoutException catch (e) {
+          expect(e, isA<TimeoutException>());
+        }
+      });
+    });
+
     testWidgets('submitting a string input with TAB (title)', (tester) async {
       return await tester.runAsync(() async {
         // Load the property editor.
@@ -474,6 +498,30 @@ void main() {
       });
     });
 
+    testWidgets('editing a numeric input to its default value (height)', (
+      tester,
+    ) async {
+      return await tester.runAsync(() async {
+        // Load the property editor.
+        controller.initForTestsOnly(editableArgsResult: result1);
+        await tester.pumpWidget(wrap(propertyEditor));
+
+        // Edit the height.
+        final heightInput = _findTextFormField('height');
+        await _inputText(heightInput, text: '20.0', tester: tester);
+
+        // Verify it doesn't trigger an edit.
+        try {
+          await nextEditCompleter.future.timeout(
+            const Duration(milliseconds: 100),
+          );
+          fail('nextEditCompleter was unexpectedly completed.');
+        } on TimeoutException catch (e) {
+          expect(e, isA<TimeoutException>());
+        }
+      });
+    });
+
     testWidgets('submitting a numeric input with TAB (height)', (tester) async {
       return await tester.runAsync(() async {
         // Load the property editor.