Respond to PR comments

Author: elliette

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart

@@ -88,23 +88,13 @@ class PropertyEditorController extends DisposableController
   void filterData(Filter<EditableProperty> filter) {
     super.filterData(filter);
     final filtered = (_editableWidgetData.value?.properties ?? []).where(
-      (property) => property.matchesSearchToken(
-        RegExp(filter.queryFilter.query, caseSensitive: false),
-      ),
+      (property) => property.matchesQuery(filter.queryFilter.query),
     );
     filteredData
       ..clear()
       ..addAll(filtered);
   }
 
-  @override
-  void setActiveFilter({
-    String? query,
-    SettingFilters<EditableArgument>? settingFilters,
-  }) {
-    super.setActiveFilter(query: query);
-  }
-
   Future<EditArgumentResponse?> editArgument<T>({
     required String name,
     required T value,

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_types.dart

@@ -132,7 +132,7 @@ class EditableEnum extends EditableProperty with FiniteValuesProperty {
   }
 }
 
-class EditableProperty extends EditableArgument with SearchableDataMixin {
+class EditableProperty extends EditableArgument {
   EditableProperty(EditableArgument argument)
     : super(
         name: argument.name,
@@ -170,11 +170,11 @@ class EditableProperty extends EditableArgument with SearchableDataMixin {
     throw UnimplementedError();
   }
 
-  @override
-  bool matchesSearchToken(RegExp regExpSearch) {
-    return name.caseInsensitiveContains(regExpSearch) ||
-        valueDisplay.caseInsensitiveContains(regExpSearch) ||
-        type.caseInsensitiveContains(regExpSearch);
+  bool matchesQuery(String query) {
+    final regExpQuery = RegExp(query, caseSensitive: false);
+    return name.caseInsensitiveContains(regExpQuery) ||
+        valueDisplay.caseInsensitiveContains(regExpQuery) ||
+        type.caseInsensitiveContains(regExpQuery);
   }
 }
 

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_view.dart

@@ -358,7 +358,7 @@ class _WidgetNameAndDocumentation extends StatelessWidget {
             ),
           ],
         ),
-        const PaddedDivider(padding: EdgeInsets.all(noPadding)),
+        const PaddedDivider.noPadding(),
       ],
     );
   }