Address review feedback for Network tab lifecycle fixes.

Keep search enabled when paused with visible requests, handle RPC errors
during clear, and wrap isolate profiling re-enable in allowedError.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: muhammadkamel

packages/devtools_app/lib/src/screens/network/network_controller.dart

@@ -197,7 +197,7 @@ class NetworkController extends DevToolsScreenController
         _,
       ) async {
         if (_recordingNotifier.value) {
-          await _enableNetworkTrafficRecordingOnAllIsolates();
+          await allowedError(_enableNetworkTrafficRecordingOnAllIsolates());
         }
       }),
     );

packages/devtools_app/lib/src/screens/network/network_screen.dart

@@ -205,6 +205,7 @@ class _NetworkProfilerControlsState extends State<_NetworkProfilerControls>
     }
 
     final screenWidth = ScreenSize(context).width;
+    final hasRequests = controller.filteredData.value.isNotEmpty;
     return Column(
       children: [
         Row(
@@ -232,7 +233,7 @@ class _NetworkProfilerControlsState extends State<_NetworkProfilerControls>
             Expanded(
               child: SearchField<NetworkController>(
                 searchController: controller,
-                searchFieldEnabled: _recording,
+                searchFieldEnabled: _recording || hasRequests,
                 searchFieldWidth: screenWidth <= MediaSize.xs
                     ? defaultSearchFieldWidth
                     : wideSearchFieldWidth,

packages/devtools_app/lib/src/screens/network/network_service.dart

@@ -205,12 +205,18 @@ class NetworkService {
     final service = serviceConnection.serviceManager.service;
     if (service == null) return;
 
-    final timestamp = (await service.getVMTimelineMicros()).timestamp!;
-    networkController.lastSocketDataRefreshMicros = timestamp;
-    await service.forEachIsolate((isolate) async {
-      lastHttpDataRefreshTimePerIsolate[isolate.id!] = timestamp;
-    });
-    await _clearSocketProfile();
-    await _clearHttpProfile();
+    try {
+      final timestamp = (await service.getVMTimelineMicros()).timestamp!;
+      networkController.lastSocketDataRefreshMicros = timestamp;
+      await service.forEachIsolate((isolate) async {
+        lastHttpDataRefreshTimePerIsolate[isolate.id!] = timestamp;
+      });
+      await _clearSocketProfile();
+      await _clearHttpProfile();
+    } on RPCError catch (e) {
+      if (!e.isServiceDisposedError) {
+        rethrow;
+      }
+    }
   }
 }

packages/devtools_app/test/screens/network/network_profiler_test.dart

@@ -65,6 +65,8 @@ void main() {
 
   group('Network Profiler', () {
     setUp(() {
+      socketProfile = loadSocketProfile();
+      httpProfile = loadHttpProfile();
       fakeServiceConnection = FakeServiceConnectionManager(
         service: FakeServiceManager.createFakeService(
           socketProfile: socketProfile,
@@ -369,6 +371,31 @@ void main() {
         await clearTimeouts(tester);
       },
     );
+
+    testWidgetsWithWindowSize(
+      'search field stays enabled when recording is paused with requests',
+      windowSize,
+      (WidgetTester tester) async {
+        controller = NetworkController();
+        await pumpNetworkScreen(tester);
+        await loadRequestsAndCheck(tester);
+
+        await tester.tap(find.byType(StartStopRecordingButton));
+        await tester.pumpAndSettle();
+
+        expect(controller.isPolling, isFalse);
+
+        final searchField = tester.widget<TextField>(
+          find.byWidgetPredicate(
+            (widget) =>
+                widget is TextField && widget.decoration?.hintText == 'Search',
+          ),
+        );
+        expect(searchField.enabled, isTrue);
+
+        await clearTimeouts(tester);
+      },
+    );
   });
 
   group('NetworkRequestOverviewView', () {