Swallow exceptions related to an already disposed service connection (#9265)

Author: kenzieschmoll

packages/devtools_app/lib/src/screens/network/network_service.dart

@@ -4,6 +4,7 @@
 
 import 'package:vm_service/vm_service.dart';
 
+import '../../service/vm_service_wrapper.dart';
 import '../../shared/globals.dart';
 import '../../shared/primitives/utils.dart';
 import '../../shared/utils/utils.dart';
@@ -68,23 +69,31 @@ class NetworkService {
     DebounceCancelledCallback? cancelledCallback,
   }) async {
     if (serviceConnection.serviceManager.service == null) return;
-    final timestampObj = await serviceConnection.serviceManager.service!
-        .getVMTimelineMicros();
-    if (cancelledCallback?.call() ?? false) return;
+    try {
+      final timestampObj = await serviceConnection.serviceManager.service!
+          .getVMTimelineMicros();
+      if (cancelledCallback?.call() ?? false) return;
 
-    final timestamp = timestampObj.timestamp!;
-    final sockets = await _refreshSockets();
-    if (cancelledCallback?.call() ?? false) return;
-
-    networkController.lastSocketDataRefreshMicros = timestamp;
-    List<HttpProfileRequest>? httpRequests;
-    httpRequests = await _refreshHttpProfile();
-    if (cancelledCallback?.call() ?? false) return;
-
-    networkController.processNetworkTraffic(
-      sockets: sockets,
-      httpRequests: httpRequests,
-    );
+      final timestamp = timestampObj.timestamp!;
+      final sockets = await _refreshSockets();
+      if (cancelledCallback?.call() ?? false) return;
+
+      networkController.lastSocketDataRefreshMicros = timestamp;
+      List<HttpProfileRequest>? httpRequests;
+      httpRequests = await _refreshHttpProfile();
+      if (cancelledCallback?.call() ?? false) return;
+
+      networkController.processNetworkTraffic(
+        sockets: sockets,
+        httpRequests: httpRequests,
+      );
+    } on RPCError catch (e) {
+      if (!e.isServiceDisposedError) {
+        // Swallow exceptions related to trying to interact with an
+        // already-disposed service connection. Otherwise, rethrow.
+        rethrow;
+      }
+    }
   }
 
   Future<List<HttpProfileRequest>> _refreshHttpProfile() async {

packages/devtools_app/lib/src/service/vm_service_wrapper.dart

@@ -69,10 +69,19 @@ class VmServiceWrapper extends VmService {
   // in https://github.com/flutter/devtools/pull/4119 as a workaround for
   // profiling the analysis server.
   Future<void> _initSupportedProtocols() async {
-    final supportedProtocols = await getSupportedProtocols();
-    final ddsProtocol = supportedProtocols.protocols?.firstWhereOrNull(
-      (Protocol p) => p.protocolName?.caseInsensitiveEquals('DDS') ?? false,
-    );
+    Protocol? ddsProtocol;
+    try {
+      final supportedProtocols = await getSupportedProtocols();
+      ddsProtocol = supportedProtocols.protocols?.firstWhereOrNull(
+        (Protocol p) => p.protocolName?.caseInsensitiveEquals('DDS') ?? false,
+      );
+    } on RPCError catch (e) {
+      if (!e.isServiceDisposedError) {
+        // Swallow exceptions related to trying to interact with an
+        // already-disposed service connection. Otherwise, rethrow.
+        rethrow;
+      }
+    }
     _ddsSupported = ddsProtocol != null;
     _supportedProtocolsInitialized.complete();
   }