Skip to content

Commit 8f8ed54

Browse files
committed
Fix network pending expectations and analyzer infos
1 parent d3d1ae7 commit 8f8ed54

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

packages/devtools_app/lib/src/shared/http/http_request_data.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,9 @@ class DartIOHttpRequestData extends NetworkRequest {
148148
//
149149
// Derived from observed cancellation wording in HTTP profiler payloads,
150150
// keeping specific terms to reduce false positives.
151-
const _cancellationMarkers = ['canceled', 'cancelled', 'aborted'];
151+
const cancellationMarkers = ['canceled', 'cancelled', 'aborted'];
152152

153-
return _cancellationMarkers.any(normalized.contains);
153+
return cancellationMarkers.any(normalized.contains);
154154
}
155155

156156
bool get _hasCancellationError {

packages/devtools_app/lib/src/shared/primitives/custom_pointer_scroll_view.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ abstract class CustomPointerScrollView extends BoxScrollView {
3131
super.physics,
3232
super.shrinkWrap,
3333
super.padding,
34-
super.cacheExtent,
34+
super.scrollCacheExtent,
3535
super.semanticChildCount,
3636
super.dragStartBehavior,
3737
this.customPointerSignalHandler,

packages/devtools_app/test/screens/network/network_table_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ void main() {
7777
expect(column.getDisplayValue(getRequest), httpGet.status);
7878

7979
final pendingRequest = findRequestById('7');
80-
expect(column.getDisplayValue(pendingRequest), 'Cancelled');
80+
expect(column.getDisplayValue(pendingRequest), '--');
8181
});
8282

8383
test('TypeColumn for http request', () {
@@ -94,7 +94,7 @@ void main() {
9494
expect(column.getDisplayValue(getRequest), '811 ms');
9595

9696
final pendingRequest = findRequestById('7');
97-
expect(column.getDisplayValue(pendingRequest), '0 μs');
97+
expect(column.getDisplayValue(pendingRequest), 'Pending');
9898
});
9999

100100
test('TimestampColumn', () {

0 commit comments

Comments
 (0)