Revert "feat: make kind chip clickable to filter logs by kind"

This reverts commit 12e96da.

Author: crackedhandle

packages/devtools_app/lib/src/screens/logging/_message_column.dart

@@ -5,7 +5,6 @@
 import 'package:devtools_app_shared/ui.dart';
 import 'package:flutter/material.dart';
 
-import '../../shared/globals.dart';
 import '../../shared/primitives/utils.dart';
 import '../../shared/table/table.dart';
 import '../../shared/table/table_data.dart';
@@ -93,14 +92,7 @@ class MessageColumn extends ColumnData<LogData>
               padding: const EdgeInsets.symmetric(vertical: densePadding),
               child: LayoutBuilder(
                 builder: (context, constraints) {
-                  return MetadataChips(
-                    data: data,
-                    onKindTapped: (kind) {
-                      final controller = screenControllers
-                          .lookup<LoggingController>();
-                      controller.setActiveFilter(query: 'k:$kind');
-                    },
-                  );
+                  return MetadataChips(data: data);
                 },
               ),
             ),

packages/devtools_app/lib/src/screens/logging/metadata.dart

@@ -14,10 +14,9 @@ import '../../shared/primitives/utils.dart';
 import 'logging_controller.dart';
 
 class MetadataChips extends StatelessWidget {
-  const MetadataChips({super.key, required this.data, this.onKindTapped});
+  const MetadataChips({super.key, required this.data});
 
   final LogData data;
-  final void Function(String kind)? onKindTapped;
 
   @override
   Widget build(BuildContext context) {
@@ -92,7 +91,6 @@ class MetadataChips extends StatelessWidget {
           iconAsset: kindIcon.iconAsset,
           backgroundColor: kindColors.background,
           foregroundColor: kindColors.foreground,
-          onTap: onKindTapped != null ? () => onKindTapped!(data.kind) : null,
         ),
         logLevelChip,
         if (elapsedFrameTimeAsString != null)
@@ -117,7 +115,6 @@ abstract class MetadataChip extends StatelessWidget {
     this.foregroundColor,
     this.outlined = false,
     this.includeLeadingMargin = true,
-    this.onTap,
   });
 
   final IconData? icon;
@@ -128,7 +125,6 @@ abstract class MetadataChip extends StatelessWidget {
   final Color? foregroundColor;
   final bool outlined;
   final bool includeLeadingMargin;
-  final VoidCallback? onTap;
 
   static const horizontalPadding = densePadding;
   static const verticalPadding = borderPadding;
@@ -144,60 +140,50 @@ abstract class MetadataChip extends StatelessWidget {
     final foregroundColor =
         this.foregroundColor ?? theme.colorScheme.onSecondaryContainer;
 
-    Widget chip = Container(
-      decoration: BoxDecoration(
-        color: backgroundColor,
-        borderRadius: BorderRadius.circular(_borderRadius),
-        border: outlined
-            ? Border.all(color: theme.colorScheme.subtleTextColor)
+    return maybeWrapWithTooltip(
+      tooltip: tooltip,
+      child: Container(
+        decoration: BoxDecoration(
+          color: backgroundColor,
+          borderRadius: BorderRadius.circular(_borderRadius),
+          border: outlined
+              ? Border.all(color: theme.colorScheme.subtleTextColor)
+              : null,
+        ),
+        margin: includeLeadingMargin
+            ? const EdgeInsets.only(left: denseSpacing)
             : null,
-      ),
-      margin: includeLeadingMargin
-          ? const EdgeInsets.only(left: denseSpacing)
-          : null,
-      padding: const EdgeInsets.symmetric(
-        horizontal: horizontalPadding,
-        vertical: verticalPadding,
-      ),
-      child: Row(
-        mainAxisSize: MainAxisSize.min,
-        children: [
-          if (icon != null || iconAsset != null) ...[
-            DevToolsIcon(
-              icon: icon,
-              iconAsset: iconAsset,
-              size: _metadataIconSize,
-              color: foregroundColor,
-            ),
-            const SizedBox(width: iconPadding),
-          ] else
-            // Include an empty SizedBox to ensure a consistent height for the
-            // chips, regardless of whether the chip includes an icon.
-            const SizedBox(height: _metadataIconSize),
-          RichText(
-            text: TextSpan(
-              text: text,
-              style: theme
-                  .regularTextStyleWithColor(foregroundColor)
-                  .copyWith(fontSize: smallFontSize),
+        padding: const EdgeInsets.symmetric(
+          horizontal: horizontalPadding,
+          vertical: verticalPadding,
+        ),
+        child: Row(
+          mainAxisSize: MainAxisSize.min,
+          children: [
+            if (icon != null || iconAsset != null) ...[
+              DevToolsIcon(
+                icon: icon,
+                iconAsset: iconAsset,
+                size: _metadataIconSize,
+                color: foregroundColor,
+              ),
+              const SizedBox(width: iconPadding),
+            ] else
+              // Include an empty SizedBox to ensure a consistent height for the
+              // chips, regardless of whether the chip includes an icon.
+              const SizedBox(height: _metadataIconSize),
+            RichText(
+              text: TextSpan(
+                text: text,
+                style: theme
+                    .regularTextStyleWithColor(foregroundColor)
+                    .copyWith(fontSize: smallFontSize),
+              ),
             ),
-          ),
-        ],
+          ],
+        ),
       ),
     );
-
-    if (onTap != null) {
-      chip = MouseRegion(
-        cursor: SystemMouseCursors.click,
-        child: GestureDetector(
-          onTap: onTap,
-          behavior: HitTestBehavior.opaque,
-          child: chip,
-        ),
-      );
-    }
-
-    return maybeWrapWithTooltip(tooltip: tooltip, child: chip);
   }
 }
 
@@ -209,7 +195,6 @@ class KindMetaDataChip extends MetadataChip {
     super.iconAsset,
     super.backgroundColor,
     super.foregroundColor,
-    super.onTap,
   }) : super(text: kind, includeLeadingMargin: false);
 
   static ({IconData? icon, String? iconAsset}) generateIcon(String kind) {