Clean up

Author: elliette

packages/devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_controller.dart

@@ -150,19 +150,12 @@ class PropertyEditorController extends DisposableController
     super.filterData(filter);
     final filtered = (_editableWidgetData.value?.properties ?? [])
         .where((property) => property.matchesQuery(filter.queryFilter.query))
-        .where((property) => !filteredOutBySettings(property, filter: filter));
+        .where((property) => !_filteredOutBySettings(property, filter: filter));
     filteredData
       ..clear()
       ..addAll(filtered);
   }
 
-  bool filteredOutBySettings(
-    EditableProperty property, {
-    required Filter filter,
-  }) => filter.settingFilters.any(
-    (settingFilter) => !settingFilter.includeData(property),
-  );
-
   Future<EditArgumentResponse?> editArgument<T>({
     required String name,
     required T value,
@@ -221,6 +214,13 @@ class PropertyEditorController extends DisposableController
     });
   }
 
+  bool _filteredOutBySettings(
+    EditableProperty property, {
+    required Filter filter,
+  }) => filter.settingFilters.any(
+    (settingFilter) => !settingFilter.includeData(property),
+  );
+
   @visibleForTesting
   void initForTestsOnly({
     EditableArgumentsResult? editableArgsResult,

packages/devtools_app/test/standalone_ui/ide_shared/property_editor/property_editor_test.dart

@@ -999,11 +999,12 @@ Future<void> _setFilter(
   String filterSettingText, {
   required WidgetTester tester,
 }) async {
+  // Click the filter button.
   final filterButtonFinder = find.byType(DevToolsFilterButton);
-  expect(filterButtonFinder, findsOneWidget);
   await tester.tap(filterButtonFinder);
   await tester.pumpAndSettle();
 
+  // Find the checkbox for the filter and click it.
   final rowFinder = find.ancestor(
     of: find.textContaining(filterSettingText),
     matching: find.byType(Row),
@@ -1015,6 +1016,7 @@ Future<void> _setFilter(
   await tester.tap(checkboxFinder);
   await tester.pumpAndSettle();
 
+  // Click "Apply" to apply the filter and close the dialog.
   final applyFilterButtonFinder = find.byType(DialogApplyButton);
   await tester.tap(applyFilterButtonFinder);
   await tester.pumpAndSettle();