Remove unused code from shared

Author: kenzieschmoll

analysis_options.yaml

@@ -163,10 +163,12 @@ dart_code_metrics:
       # devtools_app/.
       # TODO(https://github.com/flutter/devtools/issues/9906) remove these
       # excludes as findings are resolved.
-      # Investigate internal usages of inspector_controller before removing.
+      # Investigate internal usages of inspector logic before removing.
       - lib/src/screens/inspector/**_controller.dart
+      - lib/src/shared/diagnostics/inspector_service.dart
+      - lib/src/shared/diagnostics/diagnostics_node.dart
+      
       - lib/src/service/**
-      - lib/src/shared/**
       - lib/src/standalone_ui/**
       - test/**
   rules:

packages/devtools_app/benchmark/devtools_benchmarks_test.dart

@@ -5,10 +5,10 @@
 // Note: this test was modeled after the example test from Flutter Gallery:
 // https://github.com/flutter/gallery/blob/master/test_benchmarks/benchmarks_test.dart
 
-import 'dart:convert' show JsonEncoder;
 import 'dart:io';
 
 import 'package:collection/collection.dart';
+import 'package:devtools_app/src/shared/primitives/utils.dart';
 import 'package:devtools_test/helpers.dart';
 import 'package:test/test.dart';
 import 'package:web_benchmarks/metrics.dart';
@@ -92,10 +92,7 @@ Future<void> _runBenchmarks({bool useWasm = false}) async {
 
   stdout.writeln('Web benchmark tests finished.');
 
-  expect(
-    const JsonEncoder.withIndent('  ').convert(taskResult.toJson()),
-    isA<String>(),
-  );
+  expect(taskResult.toJson().prettyPrint(), isA<String>());
   expect(taskResult.scores.keys, hasLength(DevToolsBenchmark.values.length));
 
   for (final devToolsBenchmark in DevToolsBenchmark.values) {

packages/devtools_app/benchmark/scripts/compare_benchmarks.dart

@@ -5,6 +5,7 @@
 import 'dart:convert';
 import 'dart:io';
 
+import 'package:devtools_app/src/shared/primitives/utils.dart';
 import 'package:web_benchmarks/analysis.dart';
 
 import 'utils.dart';
@@ -61,6 +62,6 @@ void compareBenchmarks(
   stdout.writeln('Baseline comparison finished.');
   stdout
     ..writeln('==== Comparison with baseline $baselineSource ====')
-    ..writeln(const JsonEncoder.withIndent('  ').convert(delta.toJson()))
+    ..writeln(delta.toJson().prettyPrint())
     ..writeln('==== End of baseline comparison ====');
 }

packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart

@@ -212,6 +212,7 @@ class _AppSizeBodyState extends State<AppSizeBody>
                   if (currentTab.key == AppSizeScreen.diffTabKey) ...[
                     const SizedBox(width: defaultSpacing),
                     DiffTreeTypeDropdown(
+                      value: controller.activeDiffTreeType.value,
                       onChanged: (newDiffTreeType) {
                         controller.changeActiveDiffTreeType(newDiffTreeType!);
                       },
@@ -278,9 +279,11 @@ class AppUnitDropdown extends StatelessWidget {
 class DiffTreeTypeDropdown extends StatelessWidget {
   const DiffTreeTypeDropdown({
     super.key,
+    required this.value,
     required this.onChanged,
   });
 
+  final DiffTreeType value;
   final ValueChanged<DiffTreeType?>? onChanged;
 
   @override

packages/devtools_app/lib/src/screens/debugger/span_parser.dart

@@ -3,11 +3,12 @@
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
 import 'dart:collection';
-import 'dart:convert';
 
 import 'package:collection/collection.dart';
 import 'package:string_scanner/string_scanner.dart';
 
+import '../../shared/primitives/utils.dart';
+
 //TODO(jacobr): cleanup.
 /// A namespace for [SpanParser] utilities.
 extension SpanParser on Never {
@@ -68,12 +69,12 @@ class Grammar {
 
   @override
   String toString() {
-    return const JsonEncoder.withIndent('  ').convert({
+    return {
       'name': name,
       'scopeName': scopeName,
       'topLevelMatcher': topLevelMatcher.toJson(),
       'repository': repository.toJson(),
-    });
+    }.prettyPrint();
   }
 }
 

packages/devtools_app/lib/src/screens/inspector/inspector_tree_controller.dart

@@ -121,7 +121,7 @@ class InspectorTreeController extends DisposableController
   final int? gaId;
 
   InspectorTreeNode createNode() =>
-      InspectorTreeNode(whenDirty: _handleDirtyNode);
+      InspectorTreeNode();
 
   SearchTargetType _searchTarget = SearchTargetType.widget;
   int _rootSetCount = 0;
@@ -284,15 +284,6 @@ class InspectorTreeController extends DisposableController
     }
   }
 
-  /// Resets the state if the root has been marked as dirty.
-  void _handleDirtyNode(InspectorTreeNode node) {
-    if (node == root) {
-      _cachedSelectedRow = null;
-      lastContentWidth = null;
-      _updateRows();
-    }
-  }
-
   void setSearchTarget(SearchTargetType searchTarget) {
     _searchTarget = searchTarget;
     refreshSearchMatches();
@@ -448,10 +439,6 @@ class InspectorTreeController extends DisposableController
     return inspectorRowHeight * index;
   }
 
-  void nodeChanged(InspectorTreeNode node) {
-    node.isDirty = true;
-  }
-
   void removeNodeFromParent(InspectorTreeNode node) {
     node.parent?.removeChild(node);
   }
@@ -767,7 +754,6 @@ class InspectorTreeController extends DisposableController
           setupChildren(diagnostic, treeNode, children, expandChildren: true);
           refreshTree(
             updateTreeAction: () {
-              nodeChanged(treeNode);
               if (treeNode == selection) {
                 expandPath(treeNode);
               }

packages/devtools_app/lib/src/screens/logging/logging_controller.dart

@@ -1016,8 +1016,6 @@ class LogData with SearchableDataMixin {
   String? _details;
   Future<String> Function()? detailsComputer;
 
-  static const prettyPrinter = JsonEncoder.withIndent('  ');
-
   String? get details => _details;
 
   bool get needsComputing => !detailsComputed.isCompleted;
@@ -1040,8 +1038,8 @@ class LogData with SearchableDataMixin {
     }
 
     try {
-      return prettyPrinter
-          .convert(jsonDecode(details!))
+      return (jsonDecode(details!) as Object?)
+          .prettyPrint()
           .replaceAll(r'\n', '\n')
           .trim();
     } catch (_) {

packages/devtools_app/lib/src/shared/analytics/_analytics_web.dart

@@ -3,6 +3,7 @@
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
 // ignore_for_file: non_constant_identifier_names
+// ignore_for_file: unused-code, platform specific imports.
 
 import 'dart:async';
 

packages/devtools_app/lib/src/shared/analytics/analytics_controller.dart

@@ -43,8 +43,6 @@ bool get isAnalyticsEnabled =>
 /// Whether the analytics controller has been initialized.
 bool get isAnalyticsControllerInitialized => _analyticsController != null;
 
-typedef AsyncAnalyticsCallback = FutureOr<void> Function();
-
 class AnalyticsController {
   AnalyticsController({
     required bool enabled,
@@ -67,6 +65,7 @@ class AnalyticsController {
   ValueListenable<bool> get shouldPrompt => _shouldPrompt;
   final ValueNotifier<bool> _shouldPrompt;
 
+  @visibleForTesting
   bool get analyticsInitialized => _analyticsInitialized;
   bool _analyticsInitialized = false;
 

packages/devtools_app/lib/src/shared/analytics/constants.dart

@@ -99,13 +99,6 @@ const inspectorSettings = 'inspectorSettings';
 const loggingSettings = 'loggingSettings';
 const refreshPubRoots = 'refreshPubRoots';
 
-enum InspectorDetailsViewType { layoutExplorer, widgetDetailsTree }
-
-final defaultDetailsViewToLayoutExplorer =
-    InspectorDetailsViewType.layoutExplorer.name;
-final defaultDetailsViewToWidgetDetails =
-    InspectorDetailsViewType.widgetDetailsTree.name;
-
 enum HomeScreenEvents { connectToApp, connectToNewApp, viewVmFlags }
 
 // Logging UX actions: