Skip to content

Commit c865138

Browse files
committed
fix: failed tests
1 parent bfb9fb4 commit c865138

1 file changed

Lines changed: 42 additions & 18 deletions

File tree

packages/devtools_app/test/shared/http/http_request_data_test.dart

Lines changed: 42 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,45 @@ import 'package:flutter_test/flutter_test.dart';
33

44
void main() {
55
group('responseBytes', () {
6-
Map<String, dynamic> baseJson(Map<String, Object?> headers) {
6+
Map<String, Object?> baseJson(Map<String, Object?> responseHeaders) {
77
return {
8+
'isolateId': 'isolate-1',
9+
'id': 'request-1',
810
'method': 'GET',
911
'uri': 'https://example.com',
10-
'status': 200,
11-
'responseHeaders': headers,
12+
'events': <Object?>[],
13+
'startTime': DateTime.now().microsecondsSinceEpoch,
14+
'endTime': DateTime.now().microsecondsSinceEpoch,
15+
'request': {
16+
'headers': <String, Object?>{},
17+
'connectionInfo': null,
18+
'contentLength': null,
19+
'cookies': <Object?>[],
20+
'followRedirects': true,
21+
'maxRedirects': 5,
22+
'persistentConnection': true,
23+
},
24+
'response': {
25+
'headers': responseHeaders,
26+
'connectionInfo': null,
27+
'contentLength': null,
28+
'cookies': <Object?>[],
29+
'compressionState': 'ResponseBodyCompressionState.notCompressed',
30+
'isRedirect': false,
31+
'persistentConnection': true,
32+
'reasonPhrase': 'OK',
33+
'statusCode': 200,
34+
'startTime': DateTime.now().microsecondsSinceEpoch,
35+
},
1236
};
1337
}
1438

1539
// Verifies parsing when content-length is a string value.
1640
test('parses content-length from string', () {
1741
final request = DartIOHttpRequestData.fromJson(
1842
baseJson({'content-length': '1234'}),
19-
null, // requestPostData not used for this test
20-
null, // responseContent not used for this test
43+
null,
44+
null,
2145
);
2246

2347
expect(request.responseBytes, 1234);
@@ -26,9 +50,11 @@ void main() {
2650
// Verifies parsing when content-length is a list of strings.
2751
test('parses content-length from list of strings', () {
2852
final request = DartIOHttpRequestData.fromJson(
29-
baseJson({'content-length': '5678'}),
30-
null, // requestPostData not used for this test
31-
null, // responseContent not used for this test
53+
baseJson({
54+
'content-length': ['5678'],
55+
}),
56+
null,
57+
null,
3258
);
3359

3460
expect(request.responseBytes, 5678);
@@ -37,21 +63,19 @@ void main() {
3763
// Ensures integer values inside a list are handled correctly.
3864
test('handles integer in list', () {
3965
final request = DartIOHttpRequestData.fromJson(
40-
baseJson({'content-length': '91011'}),
41-
null, // requestPostData not used for this test
42-
null, // responseContent not used for this test
66+
baseJson({
67+
'content-length': [91011],
68+
}),
69+
null,
70+
null,
4371
);
4472

4573
expect(request.responseBytes, 91011);
4674
});
4775

4876
// Returns null when header is missing.
4977
test('returns null for missing header', () {
50-
final request = DartIOHttpRequestData.fromJson(
51-
baseJson({}), // No content-length header
52-
null, // requestPostData not used for this test
53-
null, // responseContent not used for this test
54-
);
78+
final request = DartIOHttpRequestData.fromJson(baseJson({}), null, null);
5579

5680
expect(request.responseBytes, null);
5781
});
@@ -60,8 +84,8 @@ void main() {
6084
test('returns null for invalid value', () {
6185
final request = DartIOHttpRequestData.fromJson(
6286
baseJson({'content-length': 'invalid'}),
63-
null, // requestPostData not used for this test
64-
null, // responseContent not used for this test
87+
null,
88+
null,
6589
);
6690

6791
expect(request.responseBytes, null);

0 commit comments

Comments
 (0)