network: Fix bad HAR data

Author: srawlins

packages/devtools_app/lib/src/screens/network/har_data_entry.dart

@@ -6,6 +6,7 @@ import 'dart:convert';
 import 'dart:typed_data';
 
 import '../../screens/network/utils/http_utils.dart';
+import '../../shared/http/constants.dart' as shared_http;
 import '../../shared/http/http_request_data.dart';
 import 'constants.dart';
 
@@ -45,6 +46,16 @@ class HarDataEntry {
     final requestPostData = responseData[NetworkEventKeys.postData.name];
     final responseContent = responseData[NetworkEventKeys.content.name];
 
+    final statusValue = responseData[NetworkEventKeys.status.name];
+    int? statusCode;
+    if (statusValue is int) {
+      statusCode = statusValue;
+    } else if (statusValue is String) {
+      statusCode = int.tryParse(statusValue);
+    }
+    responseData[shared_http.HttpRequestDataKeys.statusCode.name] =
+        statusCode ?? -1;
+
     return HarDataEntry(
       DartIOHttpRequestData.fromJson(
         modifiedRequestData,
@@ -148,7 +159,7 @@ class HarDataEntry {
       },
       // Response
       NetworkEventKeys.response.name: <String, Object?>{
-        NetworkEventKeys.status.name: e.status,
+        NetworkEventKeys.status.name: int.tryParse(e.status ?? '') ?? -1,
         NetworkEventKeys.statusText.name:
             e.general[NetworkEventKeys.reasonPhrase.name] ?? '',
         NetworkEventKeys.httpVersion.name:

packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md

@@ -40,7 +40,7 @@ TODO: Remove this section if there are not any updates.
 
 ## Network profiler updates
 
-TODO: Remove this section if there are not any updates.
+- Fixed exported response status in HAR files so that they parse as integers instead of strings. [TODO](https://github.com/flutter/devtools/pull/TODO)
 
 ## Logging updates
 

packages/devtools_app/test/screens/network/har_network_test.dart

@@ -71,6 +71,7 @@ void main() {
       expect(harDataEntry.request.method, 'GET');
       expect(harDataEntry.request.requestHeaders, isNotEmpty);
       expect(harDataEntry.request.requestCookies, isEmpty);
+      expect(harDataEntry.request.status, '200');
     });
 
     test('toJson serializes correctly', () {
@@ -89,6 +90,11 @@ void main() {
       expect(request?['cookies'], isEmpty);
 
       expect(json['cache'], isEmpty);
+      final response = json['response'] as Map<String, Object?>?;
+      expect(response, isNotNull);
+      expect(response?['status'], 200);
+      expect(response?['statusText'], '');
+
       final timings = json['timings'] as Map<String, Object?>?;
       expect(timings?['blocked'], NetworkEventDefaults.blocked);
       expect(timings?['dns'], NetworkEventDefaults.dns);