1

Update overrides_pane.dart

Update accessibility_controller.dart

tests

Update service_extensions.dart

Author: hannah-hyj

packages/devtools_app/lib/src/screens/accessibility/accessibility_controller.dart

@@ -69,8 +69,6 @@ class AccessibilityController extends DevToolsScreenController
     );
   }
 
-
-
   void _onBrightnessChanged() {
     final value = brightness.value;
     // Values expected by Flutter framework's 'ext.flutter.brightnessOverride':

packages/devtools_app/lib/src/service/service_extensions.dart

@@ -384,11 +384,6 @@ final brightnessMode = ServiceExtensionDescription<String>.from(
   extensions.brightnessMode,
   title: 'Override brightness',
   iconData: Icons.brightness_6,
-  displayValues: [
-    'System Default',
-    'Light Mode',
-    'Dark Mode',
-  ],
   gaScreenName: gac.accessibility,
   gaItem: gac.brightnessOverride,
   tooltip: 'Override Brightness',

packages/devtools_app/test/screens/accessibility/accessibility_screen_test.dart

@@ -181,5 +181,36 @@ void main() {
         expect(controller.highContrast.value, isTrue);
       },
     );
+
+    testWidgetsWithWindowSize(
+      'service extension state change updates controller brightness state',
+      windowSize,
+      (WidgetTester tester) async {
+        final fakeServiceExtensionManager =
+            serviceConnection.serviceManager.serviceExtensionManager
+                as FakeServiceExtensionManager;
+
+        await pumpAccessibilityScreen(tester);
+        await tester.pumpAndSettle();
+
+        expect(controller.brightness.value, BrightnessOverride.system);
+
+        // Simulate service extension state change from device to dark mode
+        fakeServiceExtensionManager.fakeServiceExtensionStateChanged(
+          brightnessMode.extension,
+          'Brightness.dark',
+        );
+        await tester.pumpAndSettle();
+        expect(controller.brightness.value, BrightnessOverride.dark);
+
+        // Simulate service extension state change from device to light mode
+        fakeServiceExtensionManager.fakeServiceExtensionStateChanged(
+          brightnessMode.extension,
+          'Brightness.light',
+        );
+        await tester.pumpAndSettle();
+        expect(controller.brightness.value, BrightnessOverride.light);
+      },
+    );
   });
 }

packages/devtools_app_shared/test/service/service_extensions_test.dart

@@ -0,0 +1,32 @@
+// Copyright 2026 The Flutter Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
+
+import 'package:devtools_app_shared/service_extensions.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('ServiceExtensions', () {
+    test('brightnessMode is properly configured', () {
+      expect(
+        brightnessMode.extension,
+        equals('ext.flutter.brightnessOverride'),
+      );
+      expect(
+        brightnessMode.values,
+        equals(['system', 'Brightness.light', 'Brightness.dark']),
+      );
+      expect(
+        serviceExtensionsAllowlist[brightnessMode.extension],
+        equals(brightnessMode),
+      );
+    });
+
+    test('brightnessMode is in unsafe before first frame set', () {
+      expect(
+        isUnsafeBeforeFirstFlutterFrame('ext.flutter.brightnessOverride'),
+        isTrue,
+      );
+    });
+  });
+}